libpayload: Cache copy of `cb_framebuffer` struct
commit5e0db58533c1d796129a0a29e03f1ca8e0e81063
authorNico Huber <nico.h@gmx.de>
Sat, 18 Jul 2020 13:20:00 +0000 (18 15:20 +0200)
committerPatrick Georgi <pgeorgi@google.com>
Mon, 24 Aug 2020 09:13:16 +0000 (24 09:13 +0000)
tree1a6054dfdffc72d145c5e28bae8835d7f6efe94e
parentbe842cb72d83b347bbc1c3308909f4eac286b47a
libpayload: Cache copy of `cb_framebuffer` struct

Our AArch64 code supports dynamic framebuffer allocation which
makes it necessary to change the framebuffer information during
runtime. Having a pointer inside `libsysinfo` made a mess of it
as the pointer would either refer to the original struct inside
the coreboot table or to a new struct inside payload space. The
latter would be unaffected by a relocation of the payload.

Instead of the pointer, we'll always keep a copy of the whole
struct, which can be altered on demand without affecting the
coreboot table. To align the `video/graphics` driver with the
console driver, we also replace `fbaddr` with a macro `FB` that
calls phys_to_virt().

Change-Id: I3edc09cdb502a71516c1ee71457c1f8dcd01c119
Signed-off-by: Nico Huber <nico.h@gmx.de>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/43578
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Angel Pons <th3fanbus@gmail.com>
Reviewed-by: Julius Werner <jwerner@chromium.org>
payloads/libpayload/arch/arm64/mmu.c
payloads/libpayload/drivers/video/corebootfb.c
payloads/libpayload/drivers/video/graphics.c
payloads/libpayload/include/sysinfo.h
payloads/libpayload/libc/coreboot.c