intelp2m: Add Go Managing Dependencies System support
commit593b0f1f23505e2eb207649c49d2c96c46f1a2aa
authorMaxim Polyakov <max.senia.poliak@gmail.com>
Wed, 11 May 2022 19:49:14 +0000 (11 22:49 +0300)
committerFelix Held <felix-coreboot@felixheld.de>
Mon, 12 Sep 2022 12:55:05 +0000 (12 12:55 +0000)
treeb31b36b86fa57f38b710a94ec9a7793132f33511
parent5004e930532245339cf1165dcdff40b5f1824d1d
intelp2m: Add Go Managing Dependencies System support

Add go.mod containing the full name of the project according to the
docs [1]: review.coreboot.org/coreboot.git/util/intelp2m, and also,
based on this, rename the internal packages to point to the absolute
path. This will allow Go Managing Dependencies System to integrate
packages from intelp2m to third-party Go written on the Go language [1].
This also requires fixing the Golang compiler version in go.mod: use
go1.18 [2], the latest up-to-date version.

[1] https://web.archive.org/web/20220910100342/https://go.dev/doc/modules/managing-dependencies
[2] https://web.archive.org/web/20220910100206/https://tip.golang.org/doc/go1.18

[ TEST ]
1) Import the coreboot project into some go project:

$cd path/to/go-project
$go get review.coreboot.org/coreboot.git
go: downloading review.coreboot.org/coreboot.git v0.0.0-20220903004133
-39914a50ae16
go: added review.coreboot.org/coreboot.git v0.0.0-20220903004133
-39914a50ae16

Thus, 'go get' correctly downloaded the contents of the repository.

2) Import intelp2m:

$cd path/to/go-project
$go get review.coreboot.org/coreboot.git/util/intelp2m
review.coreboot.org/coreboot.git/util/intelp2m imports
./config: "./config" is relative, but relative import paths are
not supported in module mode
review.coreboot.org/coreboot.git/util/intelp2m imports
./parser: "./parser" is relative, but relative import paths are
not supported in module mode

Thus, the problem is in the package names, but after this patch, the
import should be without errors.

3) Import a repository with an incorrect url:

$cd path/to/go-project
$go get review.coreboot.org/coreboot/test
go: unrecognized import path "review.coreboot.org/coreboot/test":
reading https://review.coreboot.org/coreboot/test?go-get=1:
404 Not Found

This has not happened in previous cases.

Change-Id: I12efae31227129b8c884af10fb233f398c4094e7
Signed-off-by: Maxim Polyakov <max.senia.poliak@gmail.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/64724
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: David Hendricks <david.hendricks@gmail.com>
18 files changed:
util/intelp2m/Makefile
util/intelp2m/fields/cb/cb.go
util/intelp2m/fields/fields.go
util/intelp2m/fields/fsp/fsp.go
util/intelp2m/fields/raw/raw.go
util/intelp2m/go.mod [new file with mode: 0644]
util/intelp2m/main.go
util/intelp2m/parser/parser.go
util/intelp2m/platforms/adl/macro.go
util/intelp2m/platforms/adl/template.go
util/intelp2m/platforms/apl/macro.go
util/intelp2m/platforms/apl/template.go
util/intelp2m/platforms/cnl/macro.go
util/intelp2m/platforms/cnl/template.go
util/intelp2m/platforms/common/macro.go
util/intelp2m/platforms/lbg/macro.go
util/intelp2m/platforms/snr/macro.go
util/intelp2m/platforms/snr/template.go