util/sconfig: Drop id from struct device maintained by sconfig
commit4ebe953090df979a76b99a532b2f28e697fbf365
authorFurquan Shaikh <furquan@google.com>
Sat, 2 May 2020 22:34:42 +0000 (2 15:34 -0700)
committerFurquan Shaikh <furquan@google.com>
Thu, 7 May 2020 11:55:27 +0000 (7 11:55 +0000)
tree7888d12f2d42c57f42bd5260f03aa9e7fcecc968
parent40454b7b00a59bec178da3527d933d126ca1fbd6
util/sconfig: Drop id from struct device maintained by sconfig

This change drops the id field from struct device as used by
sconfig. It was primarily used for generating unique device names. This
was maintained within device structure so that the order in which the
device tree entries were parsed is clear. Since the ids are assigned
in parsing order, it is problematic when a device is moved from base
devicetree to override tree. The entire parsing order changes which
makes it really difficult to compare what really changed in static.c
file.

By moving the dev name assignment to happen later when doing pass0 of
static.c generation, the difference in static.c file is minimized when
adding support for override trees.

BUG=b:155549176

Change-Id: I31870ace5a2fd7d5f95ab5e30d794c3bc959ed46
Signed-off-by: Furquan Shaikh <furquan@google.com>
Reviewed-on: https://review.coreboot.org/c/coreboot/+/41005
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Aaron Durbin <adurbin@chromium.org>
util/sconfig/main.c
util/sconfig/sconfig.h