| commit | 27bd64a8be3b4e3bff883377e3a0f5ae55d176c7 | |
| author | Ronald G. Minnich <rminnich@gmail.com> | |
| Thu, 28 Feb 2013 16:47:00 +0000 (28 17:47 +0100) | ||
| committer | Ronald G. Minnich <rminnich@gmail.com> | |
| Thu, 28 Feb 2013 17:16:43 +0000 (28 18:16 +0100) | ||
| tree | a0fe9ecc77d6c27c4c2aeb5e6e56e0c84c0dd7fc | treesnapshot (tar.gz zip) |
| parent | 1bc9efaf6500f2341ec83011e550a42ea68c3901 | commitdiff |
Revert "ARMv7: drop special handling for stages.c"
This breaks booting, and in fact stages.c is always going to be special: for it to work it has to be compiled for arm only, no thumb allowed. It's probably better to leave the stages.o target in explicitly so it's clear that it has to be compiled with a particular set of flags, rather than try to remember that we must always have the default rules no break stages.c compilation. That would be a mess. I will be pushing a CL to get rid of the assembly dump, but will be a trivial fix.
This reverts commit 8f4647a24bf19a96531af9905b23ae8a2fc2675a
Change-Id: I5e3d8e5b991f6ccf4d49078378cd4615fb230ca0
Reviewed-on: http://review.coreboot.org/2554
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
This breaks booting, and in fact stages.c is always going to be special: for it to work it has to be compiled for arm only, no thumb allowed. It's probably better to leave the stages.o target in explicitly so it's clear that it has to be compiled with a particular set of flags, rather than try to remember that we must always have the default rules no break stages.c compilation. That would be a mess. I will be pushing a CL to get rid of the assembly dump, but will be a trivial fix.
This reverts commit 8f4647a24bf19a96531af9905b23ae8a2fc2675a
Change-Id: I5e3d8e5b991f6ccf4d49078378cd4615fb230ca0
Reviewed-on: http://review.coreboot.org/2554
Tested-by: build bot (Jenkins)
Reviewed-by: Ronald G. Minnich <rminnich@gmail.com>
| src/arch/armv7/Makefile.inc | diffblobblamehistory |