| commit | 22ba205f7024fd04436c1ad415c26d6961919ef4 | |
| author | Richard Spiegel <richard.spiegel@amd.corp-partner.google.com> | |
| Mon, 18 Feb 2019 22:31:33 +0000 (18 15:31 -0700) | ||
| committer | Patrick Georgi <pgeorgi@google.com> | |
| Wed, 20 Feb 2019 10:38:22 +0000 (20 10:38 +0000) | ||
| tree | 4d2034da7cd275845f28dda3f486c08e6f3aadcf | treesnapshot (tar.gz zip) |
| parent | 4d60d96497bf240357d846f253193a6a744466f6 | commitdiff |
drivers/spi/spi_flash.c: Avoid static scan false positive
Static scan-build indicates a possible invalid return from function
spi_flash_cmd_erase(). The root cause is because the scan believes it's
possible for offset to be above the end address in the first pass, thus
not setting a value for variable ret. Assign initial value of -1 to
variable ret to make checker happy.
BUG=b:112253891
TEST=build grunt
Change-Id: If548728ff90b755c69143eabff6aeff01e8fd483
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/c/31473
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
Static scan-build indicates a possible invalid return from function
spi_flash_cmd_erase(). The root cause is because the scan believes it's
possible for offset to be above the end address in the first pass, thus
not setting a value for variable ret. Assign initial value of -1 to
variable ret to make checker happy.
BUG=b:112253891
TEST=build grunt
Change-Id: If548728ff90b755c69143eabff6aeff01e8fd483
Signed-off-by: Richard Spiegel <richard.spiegel@silverbackltd.com>
Reviewed-on: https://review.coreboot.org/c/31473
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Furquan Shaikh <furquan@google.com>
| src/drivers/spi/spi_flash.c | diffblobblamehistory |