| commit | 145eb479a4e9f2c32f10d8afdfea3393395dea9b | |
| author | Jacob Garber <jgarber1@ualberta.ca> | |
| Thu, 19 Sep 2019 04:47:55 +0000 (18 22:47 -0600) | ||
| committer | Patrick Georgi <pgeorgi@google.com> | |
| Fri, 20 Sep 2019 07:18:43 +0000 (20 07:18 +0000) | ||
| tree | dc90f4e33ac3f058e2e5853c64023958bf8f1914 | treesnapshot (tar.gz zip) |
| parent | 2a93d288a8ef1239e9605cb99e0a20fed83d35fc | commitdiff |
soc/qualcomm/ipq40xx: Remove unnecessary allocation
The bus variable doesn't live outside the scope of this function, and is
only used as a convenient way for passing the pointers to all the
sub-functions, so it doesn't need to be allocated. Put it on the stack
instead. A similar fix for ipq806x was done in 0f33d8c29a
(soc/qualcomm/ipq806x: Remove unnecessary allocation).
Change-Id: Ibb1129b92e38a105e100f59e03d107de340b925c
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1294801
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35464
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
The bus variable doesn't live outside the scope of this function, and is
only used as a convenient way for passing the pointers to all the
sub-functions, so it doesn't need to be allocated. Put it on the stack
instead. A similar fix for ipq806x was done in 0f33d8c29a
(soc/qualcomm/ipq806x: Remove unnecessary allocation).
Change-Id: Ibb1129b92e38a105e100f59e03d107de340b925c
Signed-off-by: Jacob Garber <jgarber1@ualberta.ca>
Found-by: Coverity CID 1294801
Reviewed-on: https://review.coreboot.org/c/coreboot/+/35464
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
Reviewed-by: Patrick Georgi <pgeorgi@google.com>
| src/soc/qualcomm/ipq40xx/lcc.c | diffblobblamehistory |