| commit | 0dab7987866b97732c89bc8e5d676a511e6aae20 | |
| author | Fred Reitberger <reitbergerfred@gmail.com> | |
| Mon, 13 Feb 2023 20:40:23 +0000 (13 15:40 -0500) | ||
| committer | Felix Held <felix-coreboot@felixheld.de> | |
| Thu, 16 Feb 2023 15:21:02 +0000 (16 15:21 +0000) | ||
| tree | e062ed8ae6b5bc51ac70900eda8532db68e359f5 | treesnapshot (tar.gz zip) |
| parent | 2cd8fa7a0ffce8be26d97e0cfefc2effd56a8019 | commitdiff |
soc/amd/glinda: Remove non-functional APCB check
The way the PSP_APCB_FILES list is created will always insert at least a
space into it. When tested by the if, this space will prevent the else
clause from ever running and never generate a build error.
Remove the non-functional check. Instead, mainboards should select
warn_no_apcb or die_no_apcb to generate a warning message or build error
if the APCB is missing.
Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: I26b96966495dc35a8b4a0cb7d5a841f3812f2a70
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73007
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
The way the PSP_APCB_FILES list is created will always insert at least a
space into it. When tested by the if, this space will prevent the else
clause from ever running and never generate a build error.
Remove the non-functional check. Instead, mainboards should select
warn_no_apcb or die_no_apcb to generate a warning message or build error
if the APCB is missing.
Signed-off-by: Fred Reitberger <reitbergerfred@gmail.com>
Change-Id: I26b96966495dc35a8b4a0cb7d5a841f3812f2a70
Reviewed-on: https://review.coreboot.org/c/coreboot/+/73007
Reviewed-by: Martin L Roth <gaumless@gmail.com>
Tested-by: build bot (Jenkins) <no-reply@coreboot.org>
| src/soc/amd/glinda/Makefile.inc | diffblobblamehistory |