| commit | 38bf0f5042ced23779e1e0c022409d2e5eda4106 | |
| author | John Foerch <jjfoerch@earthlink.net> | |
| Wed, 23 Sep 2009 19:27:26 +0000 (23 15:27 -0400) | ||
| committer | John Foerch <jjfoerch@earthlink.net> | |
| Wed, 23 Sep 2009 19:27:26 +0000 (23 15:27 -0400) | ||
| tree | f524466af069d24b17d62568715561ff3849b5e3 | treesnapshot (tar.gz zip) |
| parent | 6c08759d2c77ec85cef72da0200160ffdb71fb6d | commitdiff |
fix issue189 (help buffer titles wrong in tab-bar)
Error was introduced in 1e1a96da42d12b107dc7c6c0041a355f9763c7a1, in which
tab-bar and new-tabs initialization was moved to create_buffer_early_hook.
The problem was that when create_buffer_early_hook runs, at the end of the
`buffer' constructor, the constructor for the subclass has not completed
running, so its fields are not filled in. At this point in construction,
the field this.key_sequence is truly "undefined".
The solution was to put a title updater for the tab onto
create_buffer_hook, which runs when all constructors have completed.
Error was introduced in 1e1a96da42d12b107dc7c6c0041a355f9763c7a1, in which
tab-bar and new-tabs initialization was moved to create_buffer_early_hook.
The problem was that when create_buffer_early_hook runs, at the end of the
`buffer' constructor, the constructor for the subclass has not completed
running, so its fields are not filled in. At this point in construction,
the field this.key_sequence is truly "undefined".
The solution was to put a title updater for the tab onto
create_buffer_hook, which runs when all constructors have completed.
| modules/new-tabs.js | diffblobblamehistory | |
| modules/tab-bar.js | diffblobblamehistory |