| commit | 35e6c4a190591c4b5285994f88ad514bdf0d0dd1 | |
| author | John Foerch <jjfoerch@earthlink.net> | |
| Thu, 12 Nov 2009 21:09:11 +0000 (12 16:09 -0500) | ||
| committer | John Foerch <jjfoerch@earthlink.net> | |
| Thu, 12 Nov 2009 21:09:11 +0000 (12 16:09 -0500) | ||
| tree | fa64abd358d80567098282b4ee8d6fbebb03b22d | treesnapshot (tar.gz zip) |
| parent | fdbb43c5b83390b0ce7b68a221b9c1224f38b39d | commitdiff |
browser-object-frames: fix error in handler
We were using a "for each/in" loop over the return value of
document.getElementsByTagName, which was incorrect, because we
are only concerned with numerically indexed properties of that
object, not its extra properties like "length". I was unable
to isolate the underlying cause for why this only sometimes
caused an error to be thrown, and I wonder if there is a bug
in mozilla such that the "length" property of an HTMLCollection
is not always seen by a "for each/in" loop.
We were using a "for each/in" loop over the return value of
document.getElementsByTagName, which was incorrect, because we
are only concerned with numerically indexed properties of that
object, not its extra properties like "length". I was unable
to isolate the underlying cause for why this only sometimes
caused an error to be thrown, and I wonder if there is a bug
in mozilla such that the "length" property of an HTMLCollection
is not always seen by a "for each/in" loop.
| modules/element.js | diffblobblamehistory |