| commit | 23a7f625de05667033fc076ad045de03d39aa407 | |
| author | David Kettler <kettler@internode.on.net> | |
| Mon, 30 Nov 2009 02:13:15 +0000 (30 12:43 +1030) | ||
| committer | David Kettler <kettler@internode.on.net> | |
| Thu, 10 Dec 2009 08:37:57 +0000 (10 19:07 +1030) | ||
| tree | e9b14a6c26cfc61707137ff296b1bd079127052f | treesnapshot (tar.gz zip) |
| parent | 24a5b61c8456508d66a18c54dfb87b91052115e4 | commitdiff |
index-webjump: insist on completions being available
Xpath webjumps fail when no completions are available. Previously
conkeror would just attempt to load as a url whatever input the user
had typed. Now an error is reported and the minibuffer is exited.
This behaviour is different from other cases where match_required is
set but the input doesn't match the completions. In those cases "No
match" is reported, but the minibuffer is not exited. This case is
different because the completer throws an error and so does not have
an opportunity to set the match_required state.
The test suite is also adjusted to suit.
Xpath webjumps fail when no completions are available. Previously
conkeror would just attempt to load as a url whatever input the user
had typed. Now an error is reported and the minibuffer is exited.
This behaviour is different from other cases where match_required is
set but the input doesn't match the completions. In those cases "No
match" is reported, but the minibuffer is not exited. This case is
different because the completer throws an error and so does not have
an opportunity to set the match_required state.
The test suite is also adjusted to suit.
| modules/index-webjump.js | diffblobblamehistory | |
| tests/simple/index-webjump.js | diffblobblamehistory |