From ccdf5ad6dc56ee2cab3db2f1d9ea650d90373120 Mon Sep 17 00:00:00 2001 From: msw Date: Tue, 2 Jun 2015 13:03:02 -0700 Subject: [PATCH] Run html_viewer_apptests without a headless UI flag. Add mojo/tools/.* to the analyze step exceptions. (makes the CQ always run all steps for changes there) (so chromium_linux_gn_rel runs mojo_apptest for CLs like this) BUG=NONE TEST=Test passes locally and on Linux bots. R=jam@chromium.org,dpranke@chromium.org NOTRY=TRUE Review URL: https://codereview.chromium.org/1162263003 Cr-Commit-Position: refs/heads/master@{#332455} --- mojo/tools/data/apptests | 7 +++---- testing/buildbot/trybot_analyze_config.json | 1 + 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/mojo/tools/data/apptests b/mojo/tools/data/apptests index 20823b985a96..97538c6e2218 100644 --- a/mojo/tools/data/apptests +++ b/mojo/tools/data/apptests @@ -11,9 +11,9 @@ # # Optional display name (otherwise the entry for "test" above is used). # "name": "mojo:test_app_url (more details)", # # Optional test type. Valid values: -# # * "gtest" (default) -# # * "gtest_isolated": like "gtest", but run with fixture isolation, -# # i.e., each test in a fresh mojo_shell) +# # * "gtest": (default) +# # * "gtest_isolated": like "gtest", but run with fixture isolation. +# # i.e., each test in a fresh mojo_shell # "type": "gtest", # # Optional arguments for the shell or test. # "args": ["--some-flag-for-the-shell", "--some-flag-for-the-test"], @@ -39,7 +39,6 @@ if config.target_os != config.OS_ANDROID: tests += [ { "test": "mojo:html_viewer_apptests", - "args": ["--is-headless"], }, { "test": "mojo:view_manager_apptests", diff --git a/testing/buildbot/trybot_analyze_config.json b/testing/buildbot/trybot_analyze_config.json index 5e12450bdfb4..5608ae4b43b7 100644 --- a/testing/buildbot/trybot_analyze_config.json +++ b/testing/buildbot/trybot_analyze_config.json @@ -31,6 +31,7 @@ "content/test/gpu/.*", "extensions/test/data/.*", "gpu/gles2_conform_support/gles2_conform_test_expectations.txt", + "mojo/tools/.*", "media/test/data/.*", "net/data/.*", "sql/test/data/.*", -- 2.11.4.GIT