From 97d960cf99954045f3569dc19df27885b830934d Mon Sep 17 00:00:00 2001 From: "anandc@chromium.org" Date: Thu, 23 May 2013 05:25:10 +0000 Subject: [PATCH] Starting to remove tests that might not be really essential. Explanations for why a particular test is being removed are below. Please correct if the reasoning is not, uh, correct and also provide the reason(s) for doing so. For seek tests: Retain only WiFi and NoConstraints network conditions. Cable may be removed because it has a higher bandwidth (5120kbps) than WiFi (1024kbps) Remove BUFFERED seek tests, because the CACHED seeks perform the same actions. This reduces the # of seek test cases from 180 to 64. For media-stats test: Retain only the 2160 and 1080 resolutions. 2160 is the highest and should be most likely to catch regressions. 1080 gives us something against which to compare performance, and is the most-expected usage. This reduces the # of media-stats tests from 11 to 8, and # of metrics calculated from 44 to 32. BUG=240899 Review URL: https://chromiumcodereview.appspot.com/14932017 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@201706 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/test/data/media/html/media_seek.html | 10 +--------- chrome/test/functional/media/media_seek_perf.py | 9 ++++----- chrome/test/functional/media/media_stat_perf.py | 6 +----- 3 files changed, 6 insertions(+), 19 deletions(-) diff --git a/chrome/test/data/media/html/media_seek.html b/chrome/test/data/media/html/media_seek.html index 5a220c61fcf2..aab2ca4e769b 100644 --- a/chrome/test/data/media/html/media_seek.html +++ b/chrome/test/data/media/html/media_seek.html @@ -18,8 +18,7 @@ var SeekTestCase = { SHORT_SEEK: 0, - LONG_SEEK: 1, - BUFFERED_SEEK: 2 + LONG_SEEK: 1 } var CachedState = { @@ -108,13 +107,6 @@ case SeekTestCase.LONG_SEEK: seekRecords[cacheState][SeekTestCase.LONG_SEEK].push(delta); log("long seek in " + delta + "ms.") - seekState = SeekTestCase.BUFFERED_SEEK; - timer.start(); - video.currentTime = 1; - break; - case SeekTestCase.BUFFERED_SEEK: - seekRecords[cacheState][SeekTestCase.BUFFERED_SEEK].push(delta); - log("buffered seek in " + delta + "ms.") IterationTest(); break; default: diff --git a/chrome/test/functional/media/media_seek_perf.py b/chrome/test/functional/media/media_seek_perf.py index f48a0cd63429..89eb2f3f8e05 100755 --- a/chrome/test/functional/media/media_seek_perf.py +++ b/chrome/test/functional/media/media_seek_perf.py @@ -28,15 +28,14 @@ _TEST_HTML_PATH = os.path.join('media', 'html', 'media_seek.html') # The media files used for testing. # Path under CNS root folder (pyauto_private/media). _TEST_VIDEOS = [posixpath.join('dartmoor', name) for name in - ['dartmoor2.ogg', 'dartmoor2.m4a', 'dartmoor2.mp3', - 'dartmoor2.wav']] -_TEST_VIDEOS.extend(posixpath.join('crowd', name) for name in + ['dartmoor2.mp3', 'dartmoor2.wav']] + +_TEST_VIDEOS.extend([posixpath.join('crowd', name) for name in ['crowd1080.webm', 'crowd1080.ogv', 'crowd1080.mp4', - 'crowd360.webm', 'crowd360.ogv', 'crowd360.mp4']) + 'crowd360.webm', 'crowd360.ogv', 'crowd360.mp4']]) # Constraints to run tests on. _TESTS_TO_RUN = [ - cns_test_base.Cable, cns_test_base.Wifi, cns_test_base.NoConstraints] diff --git a/chrome/test/functional/media/media_stat_perf.py b/chrome/test/functional/media/media_stat_perf.py index 3f4ea87e9f40..f2128481055b 100755 --- a/chrome/test/functional/media/media_stat_perf.py +++ b/chrome/test/functional/media/media_stat_perf.py @@ -26,17 +26,13 @@ _TEST_MEDIA_PATH_CROWD = os.path.join('pyauto_private', 'media', 'crowd') # Path under data path for test files. _TEST_MEDIA_PATH_TULIP = os.path.join('media', 'avperf', 'tulip') - # The media files used for testing. _TEST_VIDEOS = [os.path.join(_TEST_MEDIA_PATH_CROWD, name) for name in [ - 'crowd2160.webm', 'crowd1080.webm', 'crowd720.webm', 'crowd480.webm', - 'crowd360.webm']] - + 'crowd2160.webm', 'crowd1080.webm']] _TEST_VIDEOS.extend([os.path.join(_TEST_MEDIA_PATH_TULIP, name) for name in [ 'tulip2.webm', 'tulip2.wav', 'tulip2.ogv', 'tulip2.ogg', 'tulip2.mp4', 'tulip2.mp3', 'tulip2.m4a']]) - class MediaStatsPerfTest(pyauto.PyUITest): """PyAuto test container. See file doc string for more information.""" -- 2.11.4.GIT