From 5bfd97f798f52745ead0f24a18317da112193477 Mon Sep 17 00:00:00 2001 From: bnc Date: Tue, 31 Mar 2015 14:41:27 -0700 Subject: [PATCH] Remove Net.AsyncResourceHandler_RedirectHopTime histogram. * Stop collecting data. * Obsolete Net.AsyncResourceHandler_RedirectHopTime histogram. This CL essentially reverts https://crrev.com/555913002, except #include "base/time/time.h" in async_resource_handler.cc is needed by code that has been added since. BUG=395552 Review URL: https://codereview.chromium.org/1050673002 Cr-Commit-Position: refs/heads/master@{#323117} --- content/browser/loader/async_resource_handler.cc | 9 --------- content/browser/loader/async_resource_handler.h | 3 --- tools/metrics/histograms/histograms.xml | 3 +++ 3 files changed, 3 insertions(+), 12 deletions(-) diff --git a/content/browser/loader/async_resource_handler.cc b/content/browser/loader/async_resource_handler.cc index c2b5fe71d9ff..364d11f3f114 100644 --- a/content/browser/loader/async_resource_handler.cc +++ b/content/browser/loader/async_resource_handler.cc @@ -109,13 +109,6 @@ void AsyncResourceHandler::OnFollowRedirect(int request_id) { return; } - if (!redirect_start_time_.is_null()) { - UMA_HISTOGRAM_TIMES("Net.AsyncResourceHandler_RedirectHopTime", - TimeTicks::Now() - redirect_start_time_); - // Reset start time. - redirect_start_time_ = TimeTicks(); - } - ResumeIfDeferred(); } @@ -146,8 +139,6 @@ bool AsyncResourceHandler::OnRequestRedirected( if (!info->filter()) return false; - redirect_start_time_ = TimeTicks::Now(); - *defer = did_defer_ = true; OnDefer(); diff --git a/content/browser/loader/async_resource_handler.h b/content/browser/loader/async_resource_handler.h index e2954f4975a8..fb4086db4eec 100644 --- a/content/browser/loader/async_resource_handler.h +++ b/content/browser/loader/async_resource_handler.h @@ -8,7 +8,6 @@ #include #include "base/memory/ref_counted.h" -#include "base/time/time.h" #include "content/browser/loader/resource_handler.h" #include "content/browser/loader/resource_message_delegate.h" #include "url/gurl.h" @@ -78,8 +77,6 @@ class AsyncResourceHandler : public ResourceHandler, int64_t reported_transfer_size_; - base::TimeTicks redirect_start_time_; - DISALLOW_COPY_AND_ASSIGN(AsyncResourceHandler); }; diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index 87270d9871c8..6d9026d239cf 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -16680,6 +16680,9 @@ Therefore, the affected-histogram name has to have at least one dot in it. + + Data collection finished on 2015-03-31. + bnc@chromium.org The time between the call of AsyncResourceHandler::OnRequestRedirected and -- 2.11.4.GIT