From 58956c2e50e5034734a9c79776dd37bc5af23620 Mon Sep 17 00:00:00 2001 From: "felt@chromium.org" Date: Sat, 15 Feb 2014 03:12:53 +0000 Subject: [PATCH] Add a histogram "Download.FeedbackDialogEnabled" This adds a new UMA histogram, "Download.FeedbackDialogEnabled." The histogram tells us how the user responded to the opt-in reporting dialog (enabled = true, disabled = false). BUG=312533 Review URL: https://codereview.chromium.org/163433012 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@251488 0039d316-1c4b-4281-b951-d872f2087c98 --- chrome/browser/ui/views/download/download_feedback_dialog_view.cc | 3 +++ tools/metrics/histograms/histograms.xml | 7 +++++++ 2 files changed, 10 insertions(+) diff --git a/chrome/browser/ui/views/download/download_feedback_dialog_view.cc b/chrome/browser/ui/views/download/download_feedback_dialog_view.cc index ff716ea27fca..0164ec5fb6c8 100644 --- a/chrome/browser/ui/views/download/download_feedback_dialog_view.cc +++ b/chrome/browser/ui/views/download/download_feedback_dialog_view.cc @@ -4,6 +4,7 @@ #include "chrome/browser/ui/views/download/download_feedback_dialog_view.h" +#include "base/metrics/histogram.h" #include "base/prefs/pref_service.h" #include "base/supports_user_data.h" #include "chrome/browser/profiles/profile.h" @@ -92,6 +93,8 @@ bool DownloadFeedbackDialogView::OnButtonClicked(bool accepted) { DCHECK(data); data->set_currently_shown(false); + UMA_HISTOGRAM_BOOLEAN("Download.FeedbackDialogEnabled", accepted); + callback_.Run(accepted); return true; } diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml index abaee59a8824..d165d777f366 100644 --- a/tools/metrics/histograms/histograms.xml +++ b/tools/metrics/histograms/histograms.xml @@ -3203,6 +3203,13 @@ other types of suffix sets. + + + Whether the user enables dangerous download feedback reporting after viewing + the opt-in dialog. + + + How the user interacts with the file chooser when doing a "Save -- 2.11.4.GIT