From 42315506b6cf00575e0aa97e2df0d12ec75063ae Mon Sep 17 00:00:00 2001 From: "hclam@chromium.org" Date: Wed, 10 Apr 2013 15:23:01 +0000 Subject: [PATCH] IpcSocketFactory pending packet limit is too small Refactoring is underway to notify client of P2P socket that network is congested. In the mean time pending packet limit is too small and causes huge amount of packet loss, this makes WebRTC unusable. This is a temporary fix to increase this pre-defined value to 32 pending packets which accomodates 720p streams up to 5Mb/s. BUG=228956, 229737 Review URL: https://codereview.chromium.org/13992004 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@193389 0039d316-1c4b-4281-b951-d872f2087c98 --- content/renderer/p2p/ipc_socket_factory.cc | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/content/renderer/p2p/ipc_socket_factory.cc b/content/renderer/p2p/ipc_socket_factory.cc index defe31f12d0c..c98aa2ec2243 100644 --- a/content/renderer/p2p/ipc_socket_factory.cc +++ b/content/renderer/p2p/ipc_socket_factory.cc @@ -16,8 +16,8 @@ namespace content { namespace { -// TODO(sergeyu): Try adjusting these parameters to achieve optimal performance. -const int kMaxPendingPackets = 8; +// TODO(hclam): This shouldn't be a pre-defined value. Bug: crbug.com/181321. +const int kMaxPendingPackets = 32; const int kWritableSignalThreshold = 0; // IpcPacketSocket implements talk_base::AsyncPacketSocket interface -- 2.11.4.GIT