From 308f735f0a3495b9370ca254edfd3974c3d04c5d Mon Sep 17 00:00:00 2001 From: "prasadv@chromium.org" Date: Mon, 14 Apr 2014 17:39:51 +0000 Subject: [PATCH] Avoid sending host and port as query parameters while posting build request. Fix to the current logic where it passed builder host and port in query params which is not required. BUG= NOTRY=True Review URL: https://codereview.chromium.org/232913005 git-svn-id: svn://svn.chromium.org/chrome/trunk/src@263655 0039d316-1c4b-4281-b951-d872f2087c98 --- tools/post_perf_builder_job.py | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/post_perf_builder_job.py b/tools/post_perf_builder_job.py index 70d0f53a8d22..0f926b3735d1 100644 --- a/tools/post_perf_builder_job.py +++ b/tools/post_perf_builder_job.py @@ -44,7 +44,9 @@ def PostTryJob(url_params): if not url_params.get('bot'): raise ValueError('Missing bot details. Please specify bot information.') - url = 'http://%s:%s/send_try_patch' % (url_params['host'], url_params['port']) + # Pop 'host' and 'port' to avoid passing them as query params. + url = 'http://%s:%s/send_try_patch' % (url_params.pop('host'), + url_params.pop('port')) print 'Sending by HTTP' query_params = '&'.join('%s=%s' % (k, v) for k, v in url_params.iteritems()) -- 2.11.4.GIT