From 247097df8f1a490e7d7c0d84b2bd18e71feb042d Mon Sep 17 00:00:00 2001 From: newt Date: Tue, 18 Nov 2014 16:02:12 -0800 Subject: [PATCH] Suppress "TrulyRandom" lint warning, now that it's been addressed. BUG=402732 Review URL: https://codereview.chromium.org/718803002 Cr-Commit-Position: refs/heads/master@{#304705} --- .../java/src/org/chromium/chrome/browser/WebappAuthenticator.java | 4 ++++ .../java/src/org/chromium/content/browser/crypto/CipherFactory.java | 4 ++++ 2 files changed, 8 insertions(+) diff --git a/chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java b/chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java index 26ce9a33ea8c..f5c4ffad5fdf 100644 --- a/chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java +++ b/chrome/android/java/src/org/chromium/chrome/browser/WebappAuthenticator.java @@ -4,6 +4,7 @@ package org.chromium.chrome.browser; +import android.annotation.SuppressLint; import android.content.Context; import android.os.AsyncTask; import android.util.Log; @@ -189,6 +190,9 @@ public class WebappAuthenticator { } sMacKeyGenerator = new FutureTask(new Callable() { + // SecureRandomInitializer addresses the bug in SecureRandom that "TrulyRandom" + // warns about, so this lint warning can safely be suppressed. + @SuppressLint("TrulyRandom") @Override public SecretKey call() throws Exception { KeyGenerator generator = KeyGenerator.getInstance(MAC_ALGORITHM_NAME); diff --git a/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java b/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java index 4125d6689d21..ec60d2c6a15f 100644 --- a/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java +++ b/content/public/android/java/src/org/chromium/content/browser/crypto/CipherFactory.java @@ -4,6 +4,7 @@ package org.chromium.content.browser.crypto; +import android.annotation.SuppressLint; import android.os.AsyncTask; import android.os.Bundle; import android.util.Log; @@ -149,6 +150,9 @@ public class CipherFactory { */ private Callable createGeneratorCallable() { return new Callable() { + // SecureRandomInitializer addresses the bug in SecureRandom that "TrulyRandom" + // warns about, so this lint warning can safely be suppressed. + @SuppressLint("TrulyRandom") @Override public CipherData call() { // Poll random data to generate initialization parameters for the Cipher. -- 2.11.4.GIT