From 104d4b0df7c18cb20cf09a5aaa0d8e5b23151e8a Mon Sep 17 00:00:00 2001 From: azarchs Date: Mon, 16 Feb 2015 05:06:57 -0800 Subject: [PATCH] Fail orderfile verification if no matched symbols are found. Review URL: https://codereview.chromium.org/930033002 Cr-Commit-Position: refs/heads/master@{#316465} --- tools/cygprofile/check_orderfile.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/cygprofile/check_orderfile.py b/tools/cygprofile/check_orderfile.py index c1870aeecf2b..64d4335c5f5e 100755 --- a/tools/cygprofile/check_orderfile.py +++ b/tools/cygprofile/check_orderfile.py @@ -71,9 +71,9 @@ def main(): symbol_infos = symbol_extractor.SymbolInfosFromBinary(binary_filename) # Missing symbols is not an error since some of them can be eliminated through # inlining. - (misordered_pairs_count, _, _) = _CountMisorderedSymbols( + (misordered_pairs_count, matched_symbols, _) = _CountMisorderedSymbols( symbols, symbol_infos) - return misordered_pairs_count > threshold + return (misordered_pairs_count > threshold) or (matched_symbols == 0) if __name__ == '__main__': -- 2.11.4.GIT