| commit | fafe071bac241504791c2904af9fbfea476274c8 | |
| author | jschuh <jschuh@chromium.org> | |
| Mon, 14 Sep 2015 20:21:24 +0000 (14 13:21 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 14 Sep 2015 20:21:58 +0000 (14 20:21 +0000) | ||
| tree | bd4acb9766b91cfdd651eeca4aeb333c501553bf | treesnapshot (tar.gz zip) |
| parent | c161aa945c811b260f7f2981e592f63d16c3a106 | commitdiff |
Fix float to int conversion in base/numerics
This addresses the bug where range checks are incorrect when
converting from a floating point value to an integral value of
higher precision but lower width. It also reverts a previous
attempted fix that eliminated false negatives but introduced
false positives.
BUG=522989
Review URL: https://codereview.chromium.org/1338553003
Cr-Commit-Position: refs/heads/master@{#348706}
This addresses the bug where range checks are incorrect when
converting from a floating point value to an integral value of
higher precision but lower width. It also reverts a previous
attempted fix that eliminated false negatives but introduced
false positives.
BUG=522989
Review URL: https://codereview.chromium.org/1338553003
Cr-Commit-Position: refs/heads/master@{#348706}
| base/numerics/safe_conversions_impl.h | diffblobblamehistory | |
| base/numerics/safe_numerics_unittest.cc | diffblobblamehistory |