Standardize usage of virtual/override/final specifiers.
commitfa85b15991d5df67e3adf18a46a1c0fdca163568
authordcheng <dcheng@chromium.org>
Tue, 28 Oct 2014 01:13:42 +0000 (27 18:13 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 28 Oct 2014 01:13:59 +0000 (28 01:13 +0000)
tree6fd4da7fd211f67f9ccfdc05455b5a0c6537bab5
parentb5a19d4ffc9184ec221d46a88b4afa5071eb1527
Standardize usage of virtual/override/final specifiers.

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=nasko@chromium.org

Review URL: https://codereview.chromium.org/678073006

Cr-Commit-Position: refs/heads/master@{#301534}
135 files changed:
content/browser/appcache/appcache_disk_cache_unittest.cc
content/browser/battery_status/battery_status_browsertest.cc
content/browser/browser_thread_unittest.cc
content/browser/child_process_security_policy_browsertest.cc
content/browser/child_process_security_policy_unittest.cc
content/browser/compositor/buffer_queue_unittest.cc
content/browser/compositor/image_transport_factory_browsertest.cc
content/browser/compositor/software_browser_compositor_output_surface_unittest.cc
content/browser/compositor/software_output_device_x11.h
content/browser/device_monitor_udev.h
content/browser/devtools/devtools_http_handler_unittest.cc
content/browser/devtools/devtools_manager_unittest.cc
content/browser/devtools/embedded_worker_devtools_manager_unittest.cc
content/browser/devtools/protocol/tracing_handler.cc
content/browser/dom_storage/dom_storage_context_impl_unittest.cc
content/browser/dom_storage/session_storage_database_unittest.cc
content/browser/download/base_file_unittest.cc
content/browser/download/download_file_unittest.cc
content/browser/download/download_manager_impl_unittest.cc
content/browser/download/drag_download_file_browsertest.cc
content/browser/download/file_metadata_unittest_linux.cc
content/browser/download/mhtml_generation_browsertest.cc
content/browser/download/save_package_browsertest.cc
content/browser/download/save_package_unittest.cc
content/browser/fileapi/blob_url_request_job_unittest.cc
content/browser/fileapi/dragged_file_util_unittest.cc
content/browser/fileapi/file_system_context_unittest.cc
content/browser/fileapi/file_system_dir_url_request_job_unittest.cc
content/browser/fileapi/file_system_file_stream_reader_unittest.cc
content/browser/fileapi/file_system_operation_impl_unittest.cc
content/browser/fileapi/file_system_operation_impl_write_unittest.cc
content/browser/fileapi/file_system_operation_runner_unittest.cc
content/browser/fileapi/file_system_quota_client_unittest.cc
content/browser/fileapi/file_system_url_request_job_unittest.cc
content/browser/fileapi/file_system_usage_cache_unittest.cc
content/browser/fileapi/file_writer_delegate_unittest.cc
content/browser/fileapi/fileapi_message_filter_unittest.cc
content/browser/fileapi/isolated_context_unittest.cc
content/browser/fileapi/local_file_stream_reader_unittest.cc
content/browser/fileapi/local_file_stream_writer_unittest.cc
content/browser/fileapi/local_file_util_unittest.cc
content/browser/fileapi/native_file_util_unittest.cc
content/browser/fileapi/obfuscated_file_util_unittest.cc
content/browser/fileapi/plugin_private_file_system_backend_unittest.cc
content/browser/fileapi/recursive_operation_delegate_unittest.cc
content/browser/fileapi/sandbox_file_system_backend_delegate_unittest.cc
content/browser/fileapi/sandbox_file_system_backend_unittest.cc
content/browser/fileapi/transient_file_util_unittest.cc
content/browser/fileapi/upload_file_system_file_element_reader_unittest.cc
content/browser/frame_host/navigation_controller_impl_unittest.cc
content/browser/frame_host/navigation_entry_impl_unittest.cc
content/browser/frame_host/render_frame_host_manager_unittest.cc
content/browser/frame_host/render_widget_host_view_child_frame.h
content/browser/frame_host/render_widget_host_view_child_frame_unittest.cc
content/browser/frame_host/render_widget_host_view_guest.h
content/browser/frame_host/render_widget_host_view_guest_unittest.cc
content/browser/gamepad/gamepad_platform_data_fetcher_linux.h
content/browser/gamepad/gamepad_service_unittest.cc
content/browser/geofencing/geofencing_manager_unittest.cc
content/browser/geofencing/geofencing_service_unittest.cc
content/browser/geolocation/geolocation_provider_impl_unittest.cc
content/browser/geolocation/location_arbitrator_impl_unittest.cc
content/browser/geolocation/network_location_provider_unittest.cc
content/browser/geolocation/wifi_data_provider_common_unittest.cc
content/browser/geolocation/wifi_data_provider_linux.cc
content/browser/geolocation/wifi_data_provider_linux.h
content/browser/geolocation/wifi_data_provider_linux_unittest.cc
content/browser/gpu/gpu_data_manager_impl_private_unittest.cc
content/browser/gpu/shader_disk_cache_unittest.cc
content/browser/indexed_db/indexed_db_backing_store_unittest.cc
content/browser/indexed_db/indexed_db_browsertest.cc
content/browser/indexed_db/indexed_db_database_unittest.cc
content/browser/indexed_db/indexed_db_quota_client_unittest.cc
content/browser/loader/resource_dispatcher_host_unittest.cc
content/browser/loader/resource_loader_unittest.cc
content/browser/loader/resource_scheduler_unittest.cc
content/browser/manifest/manifest_browsertest.cc
content/browser/media/audio_stream_monitor_unittest.cc
content/browser/media/capture/desktop_capture_device_aura.cc
content/browser/media/capture/desktop_capture_device_aura.h
content/browser/media/capture/video_capture_oracle_unittest.cc
content/browser/media/capture/web_contents_audio_input_stream_unittest.cc
content/browser/media/capture/web_contents_video_capture_device_unittest.cc
content/browser/media/media_internals_unittest.cc
content/browser/media/webrtc_aecdump_browsertest.cc
content/browser/media/webrtc_browsertest.cc
content/browser/media/webrtc_getusermedia_browsertest.cc
content/browser/media/webrtc_identity_store_unittest.cc
content/browser/media/webrtc_internals_browsertest.cc
content/browser/net/sqlite_persistent_cookie_store_perftest.cc
content/browser/net/sqlite_persistent_cookie_store_unittest.cc
content/browser/plugin_loader_posix_unittest.cc
content/browser/power_monitor_message_broadcaster_unittest.cc
content/browser/power_profiler/power_profiler_service_unittest.cc
content/browser/quota/mock_quota_manager_unittest.cc
content/browser/quota/quota_backend_impl_unittest.cc
content/browser/quota/quota_manager_unittest.cc
content/browser/quota/quota_reservation_manager_unittest.cc
content/browser/quota/quota_temporary_storage_evictor_unittest.cc
content/browser/quota/storage_monitor_unittest.cc
content/browser/quota/usage_tracker_unittest.cc
content/browser/screen_orientation/screen_orientation_browsertest.cc
content/browser/service_worker/embedded_worker_instance_unittest.cc
content/browser/service_worker/service_worker_browsertest.cc
content/browser/service_worker/service_worker_cache_storage_manager_unittest.cc
content/browser/service_worker/service_worker_cache_unittest.cc
content/browser/service_worker/service_worker_context_request_handler_unittest.cc
content/browser/service_worker/service_worker_context_unittest.cc
content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc
content/browser/service_worker/service_worker_dispatcher_host_unittest.cc
content/browser/service_worker/service_worker_handle_unittest.cc
content/browser/service_worker/service_worker_job_unittest.cc
content/browser/service_worker/service_worker_process_manager_unittest.cc
content/browser/service_worker/service_worker_provider_host_unittest.cc
content/browser/service_worker/service_worker_registration_unittest.cc
content/browser/service_worker/service_worker_request_handler_unittest.cc
content/browser/service_worker/service_worker_storage_unittest.cc
content/browser/service_worker/service_worker_url_request_job_unittest.cc
content/browser/service_worker/service_worker_version_unittest.cc
content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc
content/browser/shared_worker/shared_worker_service_impl_unittest.cc
content/browser/site_instance_impl_unittest.cc
content/browser/speech/google_streaming_remote_engine_unittest.cc
content/browser/speech/speech_recognizer_impl_unittest.cc
content/browser/startup_task_runner_unittest.cc
content/browser/storage_partition_impl_unittest.cc
content/browser/streams/stream_unittest.cc
content/browser/streams/stream_url_request_job_unittest.cc
content/browser/time_zone_monitor_linux.cc
content/browser/tracing/tracing_controller_browsertest.cc
content/browser/transition_request_manager_unittest.cc
content/browser/udev_linux.h
content/browser/webui/web_ui_data_source_unittest.cc
content/browser/webui/web_ui_mojo_browsertest.cc
content/browser/zygote_host/zygote_host_impl_linux.h