| commit | fa52d5b3206d84ec1dfbeff8577ed00e2b804f22 | |
| author | limasdf <limasdf@gmail.com> | |
| Fri, 18 Sep 2015 00:30:52 +0000 (17 17:30 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 18 Sep 2015 00:31:28 +0000 (18 00:31 +0000) | ||
| tree | dc7a8612291d9aebf93f40bfdb78035e8b9c6cec | treesnapshot (tar.gz zip) |
| parent | 84d8bbb5f24fcf6725334558b26983463b70203f | commitdiff |
BookmarkManager: Update parent id immediately when calling navigateTo()
When removing a leaf node on bookmark tree, navigateTo() is called.
From navigateTo(), `window.location.hash = id;` does not immediately update bmm.list.parentId.
Because this, `chrome.bookmarkManagerPrivate.canPaste` is called with old parentId.
To fix this, manually immediately update bmm.list.parentId.
BUG=532494
TEST=manual(create a leaf node, delete and see there's no console error)
Review URL: https://codereview.chromium.org/1349773002
Cr-Commit-Position: refs/heads/master@{#349550}
When removing a leaf node on bookmark tree, navigateTo() is called.
From navigateTo(), `window.location.hash = id;` does not immediately update bmm.list.parentId.
Because this, `chrome.bookmarkManagerPrivate.canPaste` is called with old parentId.
To fix this, manually immediately update bmm.list.parentId.
BUG=532494
TEST=manual(create a leaf node, delete and see there's no console error)
Review URL: https://codereview.chromium.org/1349773002
Cr-Commit-Position: refs/heads/master@{#349550}
| chrome/browser/resources/bookmark_manager/js/main.js | diffblobblamehistory |