Revert of Change default code flag to NewAvatarMenu. (patchset #29 id:580001 of https...
commitf7f718b5c5927f20d1744fd0917c702f4e0c9328
authormlerman <mlerman@chromium.org>
Mon, 23 Mar 2015 16:28:29 +0000 (23 09:28 -0700)
committerCommit bot <commit-bot@chromium.org>
Mon, 23 Mar 2015 16:29:02 +0000 (23 16:29 +0000)
treed64e15108c2c581a75b079c4fdc7c8399939a402
parent7957c6df0e1f3bd7d023d8a60e0d62d457065e48
Revert of Change default code flag to NewAvatarMenu. (patchset #29 id:580001 of https://codereview.chromium.org/845373002/)

Reason for revert:
Broke Linux Valgrind tests on the waterfall. I'll need to do more testing / work on this CL before it's ready to land.

http://build.chromium.org/p/chromium.memory.fyi/builders/Linux%20Tests%20%28valgrind%29%285%29/builds/34330

Original issue's description:
> Change default code flag to NewAvatarMenu. Flags or Finch Configs still take priority, but all else being equal we should direct the user to NewAvatarMenu.
>
> This CL fixes a few issues that arise when the flag's on:
> - Missing alt text on chrome://settings
> - Unit tests for old components (OldAvatarMenu) need to force that state
> - The ProfileAvatarDownloader works automatically with NewAvatarMenu on - this needs to be accounted for so it doesn't leave images hanging around.
> - BookmarkBubbleSigninDelegate now triggers the User Menu, not a Sign in tab, on Desktop. (note this can't be easily tested in Cocoa)
>
> BUG=287883
>
> Committed: https://crrev.com/e4d285b050ab3429f7d937fde6234fcba07a360e
> Cr-Commit-Position: refs/heads/master@{#321770}

TBR=rogerta@chromium.org,shess@chromium.org,dbeam@chromium.org,noms@chromium.org,sky@chromium.org,mukai@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=287883

Review URL: https://codereview.chromium.org/1020863007

Cr-Commit-Position: refs/heads/master@{#321789}
19 files changed:
chrome/browser/notifications/message_center_settings_controller_unittest.cc
chrome/browser/profiles/profile_avatar_downloader.cc
chrome/browser/profiles/profile_avatar_downloader.h
chrome/browser/profiles/profile_info_cache.cc
chrome/browser/profiles/profile_info_cache.h
chrome/browser/profiles/profile_info_cache_unittest.cc
chrome/browser/profiles/profile_info_interface.h
chrome/browser/resources/options/browser_options_profile_list.js
chrome/browser/sync/sync_error_notifier_ash_unittest.cc
chrome/browser/ui/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc [moved from chrome/browser/ui/views/bookmarks/bookmark_bubble_sign_in_delegate_browsertest.cc with 75% similarity]
chrome/browser/ui/cocoa/bookmarks/bookmark_sync_promo_controller_unittest.mm
chrome/browser/ui/cocoa/profiles/avatar_icon_controller_unittest.mm
chrome/browser/ui/cocoa/profiles/avatar_menu_bubble_controller_unittest.mm
chrome/browser/ui/cocoa/profiles/profile_menu_controller_unittest.mm
chrome/browser/ui/views/profiles/avatar_menu_button_browsertest.cc
chrome/browser/ui/webui/signin/user_manager_screen_handler.cc
chrome/chrome_tests.gypi
chrome/test/base/testing_profile_manager.cc
components/signin/core/common/profile_management_switches.cc