[Extension Toolbar] Refactor and finish pop out logic for actions
commitf78536e0daa95933dbd5f4c868b201356dfcdf9b
authorrdevlin.cronin <rdevlin.cronin@chromium.org>
Tue, 16 Dec 2014 19:44:34 +0000 (16 11:44 -0800)
committerCommit bot <commit-bot@chromium.org>
Tue, 16 Dec 2014 19:45:09 +0000 (16 19:45 +0000)
tree0cd32ac7e258d40ae9b122414d41d4c4afef3833
parentf25cab288d618105237ae2e9138cfe59d0cf42b2
[Extension Toolbar] Refactor and finish pop out logic for actions

* Pull out the logic to "pop out" actions when they want to act
  into a separate inner class of ToolbarActionsBar.
* Make unit tests for ToolbarActionsBar also test the overflow
  container.
* Turn off "popping out" actions by default.

UI has decided that, for the time being, we want to hold off
on popping out actions. Since this is still in heavy flux,
keep it in the code base (and tested) to prevent code rot.

BUG=417441

Review URL: https://codereview.chromium.org/766263003

Cr-Commit-Position: refs/heads/master@{#308638}
13 files changed:
chrome/browser/ui/cocoa/extensions/browser_actions_controller.h
chrome/browser/ui/cocoa/extensions/browser_actions_controller.mm
chrome/browser/ui/cocoa/extensions/test_toolbar_actions_bar_helper_cocoa.mm
chrome/browser/ui/cocoa/toolbar/toolbar_controller.mm
chrome/browser/ui/cocoa/wrench_menu/wrench_menu_controller.mm
chrome/browser/ui/toolbar/OWNERS [new file with mode: 0644]
chrome/browser/ui/toolbar/test_toolbar_actions_bar_helper.h
chrome/browser/ui/toolbar/toolbar_actions_bar.cc
chrome/browser/ui/toolbar/toolbar_actions_bar.h
chrome/browser/ui/toolbar/toolbar_actions_bar_unittest.cc
chrome/browser/ui/views/toolbar/OWNERS [new file with mode: 0644]
chrome/browser/ui/views/toolbar/browser_actions_container.cc
chrome/browser/ui/views/toolbar/test_toolbar_actions_bar_helper_views.cc