| commit | f6ac23bba83170d2002016cbd9bb7376b19ba593 | |
| author | agoode <agoode@chromium.org> | |
| Tue, 26 May 2015 20:07:20 +0000 (26 13:07 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 26 May 2015 20:07:50 +0000 (26 20:07 +0000) | ||
| tree | fd5dcc740411d1fb04cee43ee77ed70f2c2ec931 | treesnapshot (tar.gz zip) |
| parent | a589df30ed070579750bedae3223be025a41785e | commitdiff |
This makes Chrome match the gdk_window_focus behavior on X.
Chrome already does the proper things to get the user's attention for show (_NET_ACTIVE_WINDOW), with XRaiseWindow as a last resort. Raising a window is the job of the window manager on X, and should not be done at the application level. A common configuration is disabling raise-on-click in the window manager. This CL makes that behavior correct again.
BUG=318937
TEST=Verify that Chrome continues to raise on click with that setting enabled in the native window manager, and does not when that setting is disabled.
Review URL: https://codereview.chromium.org/1154013002
Cr-Commit-Position: refs/heads/master@{#331414}
Chrome already does the proper things to get the user's attention for show (_NET_ACTIVE_WINDOW), with XRaiseWindow as a last resort. Raising a window is the job of the window manager on X, and should not be done at the application level. A common configuration is disabling raise-on-click in the window manager. This CL makes that behavior correct again.
BUG=318937
TEST=Verify that Chrome continues to raise on click with that setting enabled in the native window manager, and does not when that setting is disabled.
Review URL: https://codereview.chromium.org/1154013002
Cr-Commit-Position: refs/heads/master@{#331414}
| ui/views/widget/desktop_aura/x11_desktop_handler.cc | diffblobblamehistory |