Standardize usage of virtual/override/final in chrome/browser/history
commitf6708e092f1c4677bc484588ae3ba1088b842220
authordcheng <dcheng@chromium.org>
Wed, 22 Oct 2014 01:46:55 +0000 (21 18:46 -0700)
committerCommit bot <commit-bot@chromium.org>
Wed, 22 Oct 2014 04:03:38 +0000 (22 04:03 +0000)
tree69aa4c67ec701fa1f85d009afc9e3dfc9beb9bde
parent2f5be41e6ddc25cab9804910999255b539ecff1e
Standardize usage of virtual/override/final in chrome/browser/history

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=sky@chromium.org

Review URL: https://codereview.chromium.org/666673010

Cr-Commit-Position: refs/heads/master@{#300610}
28 files changed:
chrome/browser/history/chrome_history_client.h
chrome/browser/history/chrome_history_client_factory.h
chrome/browser/history/delete_directive_handler.cc
chrome/browser/history/expire_history_backend.cc
chrome/browser/history/expire_history_backend_unittest.cc
chrome/browser/history/history_backend.h
chrome/browser/history/history_backend_unittest.cc
chrome/browser/history/history_browsertest.cc
chrome/browser/history/history_database.h
chrome/browser/history/history_notifications.h
chrome/browser/history/history_service.cc
chrome/browser/history/history_service.h
chrome/browser/history/history_service_factory.h
chrome/browser/history/history_tab_helper.h
chrome/browser/history/history_unittest.cc
chrome/browser/history/in_memory_history_backend.h
chrome/browser/history/in_memory_url_index.h
chrome/browser/history/in_memory_url_index_unittest.cc
chrome/browser/history/top_sites.h
chrome/browser/history/top_sites_impl.h
chrome/browser/history/top_sites_impl_unittest.cc
chrome/browser/history/typed_url_syncable_service.h
chrome/browser/history/typed_url_syncable_service_unittest.cc
chrome/browser/history/url_index_private_data.cc
chrome/browser/history/visit_database_unittest.cc
chrome/browser/history/web_history_service.cc
chrome/browser/history/web_history_service.h
chrome/browser/history/web_history_service_factory.h