| commit | f3e2bf48bfe9afb52dc78a3c9f18fc1d246dd6b5 | |
| author | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sat, 12 Jan 2013 19:55:36 +0000 (12 19:55 +0000) | ||
| committer | xiyuan@chromium.org <xiyuan@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Sat, 12 Jan 2013 19:55:36 +0000 (12 19:55 +0000) | ||
| tree | e552bfd0da1d7610e3f224bb9f16b9a95a91ea53 | treesnapshot (tar.gz zip) |
| parent | 895ca05443d05ba7882eddec64c1ab4d7f96364f | commitdiff |
app_list: Fix UpdateIcon crash for app update.
When an app is unloaded for updating, UpdateIcon() is called. However,
GetExtension() returns NULL at this time and triggers a crash in HasOverlay().
Since HasOverlay() info is not changing, cache it in a |has_overlay_| to fix
the crash.
Also fix a potential stale title/icon problem when extension app is updated.
BUG=157996,169463
TEST=Verify app list should not cause a crash when an app is updated.
R=sky@chromium.org,benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11885006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176584 0039d316-1c4b-4281-b951-d872f2087c98
When an app is unloaded for updating, UpdateIcon() is called. However,
GetExtension() returns NULL at this time and triggers a crash in HasOverlay().
Since HasOverlay() info is not changing, cache it in a |has_overlay_| to fix
the crash.
Also fix a potential stale title/icon problem when extension app is updated.
BUG=157996,169463
TEST=Verify app list should not cause a crash when an app is updated.
R=sky@chromium.org,benwells@chromium.org
Review URL: https://chromiumcodereview.appspot.com/11885006
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@176584 0039d316-1c4b-4281-b951-d872f2087c98