| commit | ef5c7aee88bc06a4c62714e9c1d6fbd64968e795 | |
| author | rdevlin.cronin <rdevlin.cronin@chromium.org> | |
| Fri, 20 Feb 2015 23:06:56 +0000 (20 15:06 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Fri, 20 Feb 2015 23:07:23 +0000 (20 23:07 +0000) | ||
| tree | 550c24a0eea8ee105acb01ac27fef2545074dd6a | treesnapshot (tar.gz zip) |
| parent | 103bf19477cc121eee7a3c2bdc221f2874c971c3 | commitdiff |
[Extensions Toolbar Views] Override ShouldEnterPushedState in ToolbarActionView
crrev.com/48bb4848bf961d8e1b744ac6b4d8275d425279fc introduced a new behavior
for menu buttons where they don't enter pushed state if they can be dragged.
Since ToolbarActionView emulates either a LabelButton or a MenuButton depending
whether it has a popup, it should override this.
BUG=458041
Review URL: https://codereview.chromium.org/935163002
Cr-Commit-Position: refs/heads/master@{#317435}
crrev.com/48bb4848bf961d8e1b744ac6b4d8275d425279fc introduced a new behavior
for menu buttons where they don't enter pushed state if they can be dragged.
Since ToolbarActionView emulates either a LabelButton or a MenuButton depending
whether it has a popup, it should override this.
BUG=458041
Review URL: https://codereview.chromium.org/935163002
Cr-Commit-Position: refs/heads/master@{#317435}
| chrome/browser/ui/views/toolbar/toolbar_action_view.cc | diffblobblamehistory | |
| chrome/browser/ui/views/toolbar/toolbar_action_view.h | diffblobblamehistory |