| commit | eec7904ff5ce85c3cf4fead7890c889d418aff14 | |
| author | dbeam <dbeam@chromium.org> | |
| Tue, 5 May 2015 03:22:44 +0000 (4 20:22 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 5 May 2015 03:23:17 +0000 (5 03:23 +0000) | ||
| tree | f5173a9060af9d109ba97ee9a6b38d12d3e2c8ed | treesnapshot (tar.gz zip) |
| parent | 86b2cb8e894ddf292e83b5bd1d03e9cc93d18b3f | commitdiff |
Revert of Change the callsites of InterfacePtr<> methods which directly deal with message pipe handles. (patchset #3 id:40001 of https://codereview.chromium.org/1120753004/)
Reason for revert:
This might've broke Mac 10.9's IPC message handling(?):
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/5606
Lots of errors like this:
[361:34051:0504/184612:WARNING:ipc_mojo_bootstrap.cc(214)] Detected error on Mojo bootstrap channel.
[361:34051:0504/184612:WARNING:ipc_message_attachment_set.cc(37)] MessageAttachmentSet destroyed with unconsumed descriptors: 0/1
Original issue's description:
> Change the callsites of InterfacePtr<> methods which directly deal with message pipe handles.
>
> Because those methods are going to be removed.
>
> BUG=None
>
> Committed: https://crrev.com/99f65895acf2086af0755b9ea865d6ded4baecd6
> Cr-Commit-Position: refs/heads/master@{#328232}
TBR=jam@chromium.org,rockot@chromium.org,yzshen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1124553004
Cr-Commit-Position: refs/heads/master@{#328264}
Reason for revert:
This might've broke Mac 10.9's IPC message handling(?):
https://build.chromium.org/p/chromium.mac/builders/Mac10.9%20Tests%20%28dbg%29/builds/5606
Lots of errors like this:
[361:34051:0504/184612:WARNING:ipc_mojo_bootstrap.cc(214)] Detected error on Mojo bootstrap channel.
[361:34051:0504/184612:WARNING:ipc_message_attachment_set.cc(37)] MessageAttachmentSet destroyed with unconsumed descriptors: 0/1
Original issue's description:
> Change the callsites of InterfacePtr<> methods which directly deal with message pipe handles.
>
> Because those methods are going to be removed.
>
> BUG=None
>
> Committed: https://crrev.com/99f65895acf2086af0755b9ea865d6ded4baecd6
> Cr-Commit-Position: refs/heads/master@{#328232}
TBR=jam@chromium.org,rockot@chromium.org,yzshen@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=None
Review URL: https://codereview.chromium.org/1124553004
Cr-Commit-Position: refs/heads/master@{#328264}