Revert of Refactoring of Cast-related crypto code (patchset #19 id:350001 of https...
commitee9d35aa735e6616855a0a497a055b41cd3079a6
authorjochen <jochen@chromium.org>
Wed, 14 Jan 2015 12:27:07 +0000 (14 04:27 -0800)
committerCommit bot <commit-bot@chromium.org>
Wed, 14 Jan 2015 12:27:46 +0000 (14 12:27 +0000)
tree75aceabc5221da0bfe61bfe478ad85bc085853fb
parented1e90f4f980709cef6a8a9c7e0f64cfe5578cdd
Revert of Refactoring of Cast-related crypto code (patchset #19 id:350001 of https://codereview.chromium.org/792353002/)

Reason for revert:
fails to compile on Linux ChromiumOS GN https://build.chromium.org/p/chromium.chromiumos/builders/Linux%20ChromiumOS%20GN/builds/6146/steps/compile/logs/stdio

Original issue's description:
> Refactoring of Cast-related crypto code to use the same certificate validation logic in chrome.networkingPrivate API and Cast Channel authentication.
>
> Here's what's being done here:
> * Code from cast_auth_util_nss/openssl formed the basis a common Cast device validation component in /src/extensions/common/cast/cast_cert_validator*, and is now being extensively cleaned up in response to rsleevi's comments in this CL.
> * Both networking_private_crypto* and cast_auth_util* have been updated to use the new common code.
> * The current D-Bus-based implementation of VerifyDestination is going away per discussion with ChromeOS team, and is replaced with in-Chrome code in networking_private crypto*.
>
> BUG=442650
>
> Committed: https://crrev.com/ed1e90f4f980709cef6a8a9c7e0f64cfe5578cdd
> Cr-Commit-Position: refs/heads/master@{#311460}

TBR=stevenjb@chromium.org,mef@chromium.org,rsleevi@chromium.org,vadimgo@chromium.org,mfoltz@chromium.org,kmarshall@chromium.org,rockot@chromium.org,brettw@chromium.org,sheretov@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=442650

Review URL: https://codereview.chromium.org/853663003

Cr-Commit-Position: refs/heads/master@{#311461}
30 files changed:
chrome/browser/extensions/api/networking_private/crypto_verify_impl.cc
chrome/browser/extensions/api/networking_private/crypto_verify_impl.h
chrome/browser/extensions/api/networking_private/networking_private_chromeos_apitest.cc
chrome/browser/extensions/api/networking_private/networking_private_credentials_getter_chromeos.cc [deleted file]
chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_chromeos.cc [new file with mode: 0644]
chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_chromeos.h [new file with mode: 0644]
chrome/browser/extensions/api/networking_private/networking_private_verify_delegate_factory_impl.cc
chrome/chrome_browser_extensions.gypi
chrome/chrome_common.gypi
chrome/chrome_tests_unit.gypi
chrome/common/BUILD.gn
chrome/common/extensions/api/networking_private.json
chrome/common/extensions/api/networking_private/networking_private_crypto.cc
chrome/common/extensions/api/networking_private/networking_private_crypto.h
chrome/common/extensions/api/networking_private/networking_private_crypto_nss.cc
chrome/common/extensions/api/networking_private/networking_private_crypto_openssl.cc
chrome/common/extensions/api/networking_private/networking_private_crypto_unittest.cc
chrome/test/data/extensions/api_test/networking/test.js
chrome/test/data/extensions/api_test/networking_private/test.js
extensions/browser/BUILD.gn
extensions/browser/api/cast_channel/cast_auth_util.cc
extensions/browser/api/cast_channel/cast_auth_util_nss.cc [new file with mode: 0644]
extensions/browser/api/cast_channel/cast_auth_util_openssl.cc [new file with mode: 0644]
extensions/browser/api/cast_channel/cast_auth_util_unittest.cc
extensions/common/BUILD.gn
extensions/common/cast/cast_cert_validator.cc [deleted file]
extensions/common/cast/cast_cert_validator.h [deleted file]
extensions/common/cast/cast_cert_validator_nss.cc [deleted file]
extensions/common/cast/cast_cert_validator_openssl.cc [deleted file]
extensions/extensions.gyp