Move browser image path logic into ExtensionsClient
commitec1e64be203b2390029990eeca3596e0c10aed27
authorrockot <rockot@chromium.org>
Thu, 13 Nov 2014 22:06:51 +0000 (13 14:06 -0800)
committerCommit bot <commit-bot@chromium.org>
Thu, 13 Nov 2014 22:07:27 +0000 (13 22:07 +0000)
tree8a17d41a08bb05056d71d856c9e7c703824c929b
parentbf25028c580a6460ae1d8f6e1b6f05c59edad57f
Move browser image path logic into ExtensionsClient

Currently, extension_file_util::GetBrowserImagePaths
exists and provides universal logic for identifying
sensitive image paths within an extension: i.e. paths to
images which may need to be transcoded before being handed
to the browser to display in its privileged UI.

This list of images depends entirely on the extensions
embedder, so it makes sense to define it within
ExtensionsClient. That's what this CL does. It establishes
such an interface in ExtensionsClient, and moves the very
Chrome-specific logic out of
extension_file_util::GetBrowserImagePaths and into
ChromeExtensionsClient.

BUG=398671
R=scheib@chromium.org
TBR=shuchen@chromium.org,yoz@chromium.org for mechanical updates

Review URL: https://codereview.chromium.org/719403002

Cr-Commit-Position: refs/heads/master@{#304096}
16 files changed:
chrome/browser/chromeos/input_method/component_extension_ime_manager_impl.cc
chrome/browser/extensions/extension_system_impl.cc
chrome/browser/extensions/sandboxed_unpacker.cc
chrome/chrome_common.gypi
chrome/chrome_tests_unit.gypi
chrome/common/extensions/chrome_extensions_client.cc
chrome/common/extensions/chrome_extensions_client.h
chrome/common/extensions/chrome_extensions_client_unittest.cc [moved from chrome/common/extensions/extension_file_util_unittest.cc with 82% similarity]
chrome/common/extensions/extension_file_util.cc [deleted file]
chrome/common/extensions/extension_file_util.h [deleted file]
chrome/utility/extensions/unpacker.cc
extensions/common/extensions_client.h
extensions/shell/common/shell_extensions_client.cc
extensions/shell/common/shell_extensions_client.h
extensions/test/test_extensions_client.cc
extensions/test/test_extensions_client.h