| commit | e9c4d717e1147c6e7248bc071450e62ea24530f1 | |
| author | qyearsley <qyearsley@chromium.org> | |
| Thu, 29 Jan 2015 02:36:40 +0000 (28 18:36 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 29 Jan 2015 02:37:43 +0000 (29 02:37 +0000) | ||
| tree | e72622b536992d13070a40f1e2e14e9b630be9b3 | treesnapshot (tar.gz zip) |
| parent | d5eac382304b9d274bbb2c892cf02a0d3cb7b624 | commitdiff |
Run "git stash" and "git stash apply" before and after a dry test run.
Reason: We don't want to destroy local uncommited changes when running tests.
One solution was to mock bisect_utils.GitRun -- doing that caused the course of the run to change, making it so that there were no results (since git log is used to get a list of revisions, even for the dry run). So if we want to solve this problem by mocking git, we should replace it with a fake RunGit that returns different canned values depending on what the input is.
The advantage of stash/apply is that its simpler, but it's also a little bit slower than the above way.
BUG=
Review URL: https://codereview.chromium.org/847393004
Cr-Commit-Position: refs/heads/master@{#313650}
Reason: We don't want to destroy local uncommited changes when running tests.
One solution was to mock bisect_utils.GitRun -- doing that caused the course of the run to change, making it so that there were no results (since git log is used to get a list of revisions, even for the dry run). So if we want to solve this problem by mocking git, we should replace it with a fake RunGit that returns different canned values depending on what the input is.
The advantage of stash/apply is that its simpler, but it's also a little bit slower than the above way.
BUG=
Review URL: https://codereview.chromium.org/847393004
Cr-Commit-Position: refs/heads/master@{#313650}
| tools/auto_bisect/bisect_perf_regression_test.py | diffblobblamehistory |