| commit | e8fa00efd0965a7eb5816a1ef05c41e017029880 | |
| author | reillyg <reillyg@chromium.org> | |
| Thu, 9 Oct 2014 04:53:10 +0000 (8 21:53 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 9 Oct 2014 04:53:47 +0000 (9 04:53 +0000) | ||
| tree | 3b949bfd6d09e24d3ad157850b351f13002a62b5 | treesnapshot (tar.gz zip) |
| parent | efe9bba6f2d35045b588cdf05d211d246dffa46d | commitdiff |
Use IOService enumeration instead of IOHIDManager in HidServiceMac.
Using the IOServiceAddMatchingNotification API to monitor devices
connected to the system is preferable to IOHIDManager because it is
lighter weight. IOHIDManager forces its own lifetime expectations on
the IOHIDDevice objects that it creates and opens all devices it sees
for I/O whether or not there is a Chrome app that is using them.
As a necessary step to simplify this transition the device/hid API now
lives on the browser UI thread when running on OS X. This change will
soon be made for Linux and Windows as well. This change should also
reduce the risk of race conditions as observed in bug 418207 which is
why it is being made independently of the other platforms.
BUG=418207,413978
R=rockot@chromium.org,rpaquay@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/637863003
Cr-Commit-Position: refs/heads/master@{#298793}
Using the IOServiceAddMatchingNotification API to monitor devices
connected to the system is preferable to IOHIDManager because it is
lighter weight. IOHIDManager forces its own lifetime expectations on
the IOHIDDevice objects that it creates and opens all devices it sees
for I/O whether or not there is a Chrome app that is using them.
As a necessary step to simplify this transition the device/hid API now
lives on the browser UI thread when running on OS X. This change will
soon be made for Linux and Windows as well. This change should also
reduce the risk of race conditions as observed in bug 418207 which is
why it is being made independently of the other platforms.
BUG=418207,413978
R=rockot@chromium.org,rpaquay@chromium.org
TBR=thestig@chromium.org
Review URL: https://codereview.chromium.org/637863003
Cr-Commit-Position: refs/heads/master@{#298793}
18 files changed: