| commit | e652df3e915ab9720480158f261a285e4a696a77 | |
| author | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 7 Mar 2013 05:27:30 +0000 (7 05:27 +0000) | ||
| committer | mukai@chromium.org <mukai@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 7 Mar 2013 05:27:30 +0000 (7 05:27 +0000) | ||
| tree | cb6fef0338037e4f918dd8395e287fff86258c67 | treesnapshot (tar.gz zip) |
| parent | 8405db533878bac39d622c421e8c1baa9d21c0fe | commitdiff |
Revert 186612
> Remove close_on_deactivate=false for tray bubbles (2nd)
>
> Actually we want to close those bubbles on deactivation (like, opening
> settings page or opening the chat window for a notification). To deal
> with the race condition of close-on-deactivate and button action,
> a static delay is introduced.
>
> The first attempt (r184572) has been reverted due to a crash bug.
> It seems that the crash happens because of missing cleanup of system
> notification bubbles.
>
> BUG=179992, 177075
> TEST=on goobuntu, open the systme tray, wait for the power notifications, then click 'settings' and see no crash.
>
>
> Review URL: https://chromiumcodereview.appspot.com/12510005
TBR=mukai@chromium.org
Review URL: https://codereview.chromium.org/12580003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186626 0039d316-1c4b-4281-b951-d872f2087c98
> Remove close_on_deactivate=false for tray bubbles (2nd)
>
> Actually we want to close those bubbles on deactivation (like, opening
> settings page or opening the chat window for a notification). To deal
> with the race condition of close-on-deactivate and button action,
> a static delay is introduced.
>
> The first attempt (r184572) has been reverted due to a crash bug.
> It seems that the crash happens because of missing cleanup of system
> notification bubbles.
>
> BUG=179992, 177075
> TEST=on goobuntu, open the systme tray, wait for the power notifications, then click 'settings' and see no crash.
>
>
> Review URL: https://chromiumcodereview.appspot.com/12510005
TBR=mukai@chromium.org
Review URL: https://codereview.chromium.org/12580003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@186626 0039d316-1c4b-4281-b951-d872f2087c98