| commit | e649f573a38b00bb20fe0925098251a4ff184566 | |
| author | danakj <danakj@chromium.org> | |
| Thu, 8 Jan 2015 23:35:58 +0000 (8 15:35 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Thu, 8 Jan 2015 23:37:17 +0000 (8 23:37 +0000) | ||
| tree | 6f400822726e85def4cad5a1ee704e232a6364ad | treesnapshot (tar.gz zip) |
| parent | 95bc5b1779dcf8e4a9e37ef600c0ea76293307e3 | commitdiff |
base: Change DCHECK_IS_ON to a macro DCHECK_IS_ON().
This ensures that if the header is not included, and a DCHECK is guarded
by this check, that the file will fail to compile instead of silently
compiling the DCHECK out.
For example:
#if DCHECK_IS_ON
DCHECK(SomeThing());
#endif
This example would be compiled out if DCHECK_IS_ON was not defined due
to not including the logging.h header.
Instead, this will fail to compile:
#if DCHECK_IS_ON()
DCHECK(SomeThing());
#endif
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/842523002
Cr-Commit-Position: refs/heads/master@{#310626}
This ensures that if the header is not included, and a DCHECK is guarded
by this check, that the file will fail to compile instead of silently
compiling the DCHECK out.
For example:
#if DCHECK_IS_ON
DCHECK(SomeThing());
#endif
This example would be compiled out if DCHECK_IS_ON was not defined due
to not including the logging.h header.
Instead, this will fail to compile:
#if DCHECK_IS_ON()
DCHECK(SomeThing());
#endif
R=thakis@chromium.org
Review URL: https://codereview.chromium.org/842523002
Cr-Commit-Position: refs/heads/master@{#310626}
53 files changed: