| commit | e27865b72eab201b557a60b88bb648e3f8b0843f | |
| author | yukishiino <yukishiino@chromium.org> | |
| Sat, 7 Feb 2015 12:33:37 +0000 (7 04:33 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Sat, 7 Feb 2015 12:34:54 +0000 (7 12:34 +0000) | ||
| tree | f118a3ab5b8678e337d96485ef88dd637f2613bd | treesnapshot (tar.gz zip) |
| parent | b0d2c35286cfdb4a4f51b36778db89417dcb0151 | commitdiff |
webrtc: Fixes WebRtcBrowserTest to use DOM attributes correctly.
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs is assuming that DOM attributes are own properties on a JS obejct, which is not correct. Blink (binding) team is working to move DOM attributes from own properties to properties on prototype chains, and then this test will break.
This CL fixes the test so that it stringifies not only own properties but also attributes on prototype chains.
BUG=43394
Review URL: https://codereview.chromium.org/904823002
Cr-Commit-Position: refs/heads/master@{#315198}
WebRtcBrowserTest.RunsAudioVideoWebRTCCallInTwoTabs is assuming that DOM attributes are own properties on a JS obejct, which is not correct. Blink (binding) team is working to move DOM attributes from own properties to properties on prototype chains, and then this test will break.
This CL fixes the test so that it stringifies not only own properties but also attributes on prototype chains.
BUG=43394
Review URL: https://codereview.chromium.org/904823002
Cr-Commit-Position: refs/heads/master@{#315198}
| chrome/test/data/webrtc/peerconnection.js | diffblobblamehistory |