| commit | e263ba7490f1c8ec0fb017b1e8e8392ca1356f87 | |
| author | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 29 May 2013 00:26:58 +0000 (29 00:26 +0000) | ||
| committer | grt@chromium.org <grt@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Wed, 29 May 2013 00:26:58 +0000 (29 00:26 +0000) | ||
| tree | 47a09ae7ef60a059b3b4f6fc8b298d17da1270fe | treesnapshot (tar.gz zip) |
| parent | 6cf58a0487f8ae5a768d5c4338a05e8a262a85d8 | commitdiff |
Attempt to fix use-after-free in VersionUpdaterWin.
I've been unable to repro the crash, but perhaps there's a way for
VersionUpdaterWin::OnReportResults to be invoked twice. This change
detaches the VersionUpdaterWin instance from the GoogleUpdate instance
when it releases its reference.
BUG=236413,242895
R=mad@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15649007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202707 0039d316-1c4b-4281-b951-d872f2087c98
I've been unable to repro the crash, but perhaps there's a way for
VersionUpdaterWin::OnReportResults to be invoked twice. This change
detaches the VersionUpdaterWin instance from the GoogleUpdate instance
when it releases its reference.
BUG=236413,242895
R=mad@chromium.org
Review URL: https://chromiumcodereview.appspot.com/15649007
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@202707 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/ui/webui/help/version_updater_win.cc | diffblobblamehistory |