| commit | e0f868e9bb4f5ca574529d5fbc550381f6ec9db9 | |
| author | vabr <vabr@chromium.org> | |
| Wed, 21 Jan 2015 14:10:24 +0000 (21 06:10 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Wed, 21 Jan 2015 14:11:15 +0000 (21 14:11 +0000) | ||
| tree | 572c9f88df63300c4d68ad1a91238a38299475a0 | treesnapshot (tar.gz zip) |
| parent | 0eeb6a9a3b410797f88f487c2fe80170273f2723 | commitdiff |
NativeBackendKWallet::GetAllLogins should not ignore errors
Currently, if KWallet failes to respond during credential retrieval, NativeBackendKWallet::GetAllLogins just silently ignores that, unlike NativeBackendKWallet::GetLoginsList, and unlike GetAllLogins itself during presence checking.
This CL makes GetAllLogins return false whenever KWallet fails to respond, to match the rest of the NativeBackendKWallet code.
BUG=324291
Review URL: https://codereview.chromium.org/856343003
Cr-Commit-Position: refs/heads/master@{#312344}
Currently, if KWallet failes to respond during credential retrieval, NativeBackendKWallet::GetAllLogins just silently ignores that, unlike NativeBackendKWallet::GetLoginsList, and unlike GetAllLogins itself during presence checking.
This CL makes GetAllLogins return false whenever KWallet fails to respond, to match the rest of the NativeBackendKWallet code.
BUG=324291
Review URL: https://codereview.chromium.org/856343003
Cr-Commit-Position: refs/heads/master@{#312344}
| chrome/browser/password_manager/native_backend_kwallet_x.cc | diffblobblamehistory | |
| chrome/browser/password_manager/native_backend_kwallet_x_unittest.cc | diffblobblamehistory |