Standardize usage of virtual/override/final in chrome/browser/printing/
commitdf7e44a77c954eacf31c9388b0b1edb86811c963
authordcheng <dcheng@chromium.org>
Tue, 21 Oct 2014 23:50:19 +0000 (21 16:50 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 21 Oct 2014 23:50:39 +0000 (21 23:50 +0000)
tree83bb513d537fdbfe50d5caca8d9d10b304b755b9
parentbf634aa33aa21ce25ef680bca6305b9ad64acfbc
Standardize usage of virtual/override/final in chrome/browser/printing/

The Google C++ style guide states:

  Explicitly annotate overrides of virtual functions or virtual
  destructors with an override or (less frequently) final specifier.
  Older (pre-C++11) code will use the virtual keyword as an inferior
  alternative annotation. For clarity, use exactly one of override,
  final, or virtual when declaring an override.

To better conform to these guidelines, the following constructs have
been rewritten:

- if a base class has a virtual destructor, then:
    virtual ~Foo();                   ->  ~Foo() override;
- virtual void Foo() override;        ->  void Foo() override;
- virtual void Foo() override final;  ->  void Foo() final;

This patch was automatically generated. The clang plugin can generate
fixit hints, which are suggested edits when it is 100% sure it knows how
to fix a problem. The hints from the clang plugin were applied to the
source tree using the tool in https://codereview.chromium.org/598073004.

BUG=417463
R=vitalybuka@chromium.org

Review URL: https://codereview.chromium.org/668093002

Cr-Commit-Position: refs/heads/master@{#300570}
24 files changed:
chrome/browser/printing/background_printing_manager.cc
chrome/browser/printing/background_printing_manager.h
chrome/browser/printing/cloud_print/cloud_print_proxy_service.h
chrome/browser/printing/cloud_print/cloud_print_proxy_service_factory.h
chrome/browser/printing/cloud_print/cloud_print_proxy_service_unittest.cc
chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc
chrome/browser/printing/print_dialog_cloud.cc
chrome/browser/printing/print_dialog_cloud_internal.h
chrome/browser/printing/print_job.h
chrome/browser/printing/print_job_manager.h
chrome/browser/printing/print_job_unittest.cc
chrome/browser/printing/print_job_worker.cc
chrome/browser/printing/print_preview_context_menu_observer.h
chrome/browser/printing/print_preview_dialog_controller.cc
chrome/browser/printing/print_preview_dialog_controller.h
chrome/browser/printing/print_preview_dialog_controller_browsertest.cc
chrome/browser/printing/print_preview_message_handler.h
chrome/browser/printing/print_preview_pdf_generated_browsertest.cc
chrome/browser/printing/print_preview_test.cc
chrome/browser/printing/print_preview_test.h
chrome/browser/printing/print_view_manager.h
chrome/browser/printing/print_view_manager_base.h
chrome/browser/printing/printer_query.h
chrome/browser/printing/printing_message_filter.h