| commit | dacd42f18b4c995084f57c4bd632a061bb8989ba | |
| author | robliao@chromium.org <robliao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 4 Nov 2013 17:54:09 +0000 (4 17:54 +0000) | ||
| committer | robliao@chromium.org <robliao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Mon, 4 Nov 2013 17:54:09 +0000 (4 17:54 +0000) | ||
| tree | 55027820d081917a0dd0541226be07323ce891bf | treesnapshot (tar.gz zip) |
| parent | 0080014ab402356ba511237dd6e4729befd276a5 | commitdiff |
Disable Background Menu Items for Component Extensions without Options Pages
Component extensions with background that do not have an options page
will cause this menu item to go to the extensions page with an
absent component extension.
Ideally, we would remove this item, but this conflicts with the user
model where this menu shows the extensions with background.
The compromise is to disable the item, avoiding the non-actionable
navigate to the extensions page and preserving the user model.
BUG=311884
TEST=From the Chrome Background Context Menu, "Google Now" should be disabled.
Other extensions (non-component or has options page) will remain enabled.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232602
R=kalman@chromium.org, miket@chromium.org, sky@chromium.org, vadimt@chromium.org
Review URL: https://codereview.chromium.org/52553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232728 0039d316-1c4b-4281-b951-d872f2087c98
Component extensions with background that do not have an options page
will cause this menu item to go to the extensions page with an
absent component extension.
Ideally, we would remove this item, but this conflicts with the user
model where this menu shows the extensions with background.
The compromise is to disable the item, avoiding the non-actionable
navigate to the extensions page and preserving the user model.
BUG=311884
TEST=From the Chrome Background Context Menu, "Google Now" should be disabled.
Other extensions (non-component or has options page) will remain enabled.
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=232602
R=kalman@chromium.org, miket@chromium.org, sky@chromium.org, vadimt@chromium.org
Review URL: https://codereview.chromium.org/52553004
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@232728 0039d316-1c4b-4281-b951-d872f2087c98