| commit | da570e8948b6584dc18f624a40a81a165d2f3de9 | |
| author | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 26 Feb 2009 00:08:35 +0000 (26 00:08 +0000) | ||
| committer | finnur@google.com <finnur@google.com@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Thu, 26 Feb 2009 00:08:35 +0000 (26 00:08 +0000) | ||
| tree | d81c356ddb1d815057f894bfcffce25f529b19d3 | treesnapshot (tar.gz zip) |
| parent | 29d25005a8778783608c89015bdfbd25cadb7d3f | commitdiff |
We can get into a state where the automation framework presses the Close button in the Find box after the tab has been destroyed. This causes the Find box to act on a NULL web_contents_ pointer.
We now guard against this by checking for NULL web_contents before performing any work that relies on it.
(I can't reproduce this bug manually or by running the automation testing locally, but this is an attempt to fix the crash by using the information gathered from looking at the crash dump).
Review URL: http://codereview.chromium.org/27173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10414 0039d316-1c4b-4281-b951-d872f2087c98
We now guard against this by checking for NULL web_contents before performing any work that relies on it.
(I can't reproduce this bug manually or by running the automation testing locally, but this is an attempt to fix the crash by using the information gathered from looking at the crash dump).
Review URL: http://codereview.chromium.org/27173
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@10414 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/views/find_bar_win.cc | diffblobblamehistory |