Revert of mandoline filesystem: Save cookie data to the mojo:filesystem. (patchset...
commitd8eddd344341fee0aca4d5846a0f5d5ef2c2a037
authorfsamuel <fsamuel@chromium.org>
Tue, 7 Jul 2015 14:51:39 +0000 (7 07:51 -0700)
committerCommit bot <commit-bot@chromium.org>
Tue, 7 Jul 2015 14:52:53 +0000 (7 14:52 +0000)
tree03bbb8fc379be4f9d0d1d5e120e24dc6ba61a217
parent128c8573daa2a188b05db7121382d44dc73540e0
Revert of mandoline filesystem: Save cookie data to the mojo:filesystem. (patchset #16 id:300001 of https://codereview.chromium.org/1179413010/)

Reason for revert:
I'm seeing the following crash when closing the Mandoline window on Linux:

[0707/104753:FATAL:sqlite_persistent_cookie_store.cc(1135)] Check failed: false. Could not add a cookie to the DB.
#0 0x00000046aef1 __interceptor_backtrace
#1 0x7fec4b87954e base::debug::StackTrace::StackTrace()
#2 0x7fec4b479a1d logging::LogMessage::~LogMessage()
#3 0x7fec53f03c23 net::SQLitePersistentCookieStore::Backend::Commit()
#4 0x7fec53f04f38 net::SQLitePersistentCookieStore::Backend::InternalBackgroundClose()
#5 0x7fec53f1902b base::internal::RunnableAdapter<>::Run()

Reverting this patch resolves the issue.

Original issue's description:
> mandoline filesystem: Save cookie data to the mojo:filesystem.
>
> This makes the network service use the sql vfs to proxy writing the
> cookies to the filesystem service. This means mojo:network_service does
> not directly write its data to the OS filesystem, which will allow us to
> sandbox it.
>
> BUG=493311
>
> Committed: https://crrev.com/bbb9e2f6486cccadde4dc2fa077af8f694105eaa
> Cr-Commit-Position: refs/heads/master@{#337491}

TBR=jam@chromium.org,msw@chromium.org,sky@chromium.org,shess@chromium.org,erg@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=493311

Review URL: https://codereview.chromium.org/1225673006

Cr-Commit-Position: refs/heads/master@{#337602}
19 files changed:
components/filesystem/file_system_impl.cc
components/filesystem/file_system_impl.h
mandoline/services/core_services/core_services_application_delegate.cc
mojo/runner/BUILD.gn
mojo/runner/child_process_host.cc
mojo/runner/context.h
mojo/runner/scoped_user_data_dir.cc [deleted file]
mojo/runner/scoped_user_data_dir.h [deleted file]
mojo/runner/switches.cc
mojo/runner/switches.h
mojo/services/network/BUILD.gn
mojo/services/network/DEPS
mojo/services/network/network_context.cc
mojo/services/network/network_context.h
mojo/services/network/network_service_delegate.cc
mojo/services/network/network_service_delegate.h
mojo/tools/mopy/gtest.py
sql/mojo/mojo_vfs.cc
sql/mojo/vfs_unittest.cc