| commit | d65b735d987b4098074fecbd9fd910642457c3da | |
| author | rohitrao@chromium.org <rohitrao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 21 Sep 2010 16:15:49 +0000 (21 16:15 +0000) | ||
| committer | rohitrao@chromium.org <rohitrao@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 21 Sep 2010 16:15:49 +0000 (21 16:15 +0000) | ||
| tree | 088823c90ed2d1205b5ac6d43e816edb92aeaeca | treesnapshot (tar.gz zip) |
| parent | af1654c383cddf88f5bcade6949f96a90c3f1790 | commitdiff |
[Mac] Explicitly set Space when existing full screen
If a user moves the full screen window to a different space they get snapped back to the original space when they exit full screen.
The problem is that internally the full screen window is a different window than the normal browser window. This means that any changes the user makes to the full screen window aren't reflected on the normal browser window.
The correct fix for this bug is to create a new browser window when the user exits full screen. This new window would then be on the correct space. This would require a fairly large architectural change to the BrowserWindowController class.
My proposed fix is much simpler. When exiting full screen we simply move the normal browser window to the Space that the full screen window is on.
Original review at: http://codereview.chromium.org/3345005/show
Patch by Sailesh Agrawal <fnepal@gmail.com>.
BUG=41693
TEST=Moved the full screen window to a different Space. Verified that exiting full screen didn't change the active Space.
Review URL: http://codereview.chromium.org/3386015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60063 0039d316-1c4b-4281-b951-d872f2087c98
If a user moves the full screen window to a different space they get snapped back to the original space when they exit full screen.
The problem is that internally the full screen window is a different window than the normal browser window. This means that any changes the user makes to the full screen window aren't reflected on the normal browser window.
The correct fix for this bug is to create a new browser window when the user exits full screen. This new window would then be on the correct space. This would require a fairly large architectural change to the BrowserWindowController class.
My proposed fix is much simpler. When exiting full screen we simply move the normal browser window to the Space that the full screen window is on.
Original review at: http://codereview.chromium.org/3345005/show
Patch by Sailesh Agrawal <fnepal@gmail.com>.
BUG=41693
TEST=Moved the full screen window to a different Space. Verified that exiting full screen didn't change the active Space.
Review URL: http://codereview.chromium.org/3386015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@60063 0039d316-1c4b-4281-b951-d872f2087c98
| chrome/browser/cocoa/browser_window_controller.mm | diffblobblamehistory | |
| chrome/browser/cocoa/nswindow_additions.h | [new file with mode: 0644] | blob |
| chrome/browser/cocoa/nswindow_additions.mm | [new file with mode: 0644] | blob |
| chrome/chrome_browser.gypi | diffblobblamehistory |