Revert of Add a Restore() method to ValueStore and make StorageAPI use it (https...
commitd3c5b736bfa7ee1f48bd5712e9ef8349147bf1ec
authorrdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 21 Feb 2014 21:44:35 +0000 (21 21:44 +0000)
committerrdevlin.cronin@chromium.org <rdevlin.cronin@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Fri, 21 Feb 2014 21:44:35 +0000 (21 21:44 +0000)
treeb20e1b63aceca5ee11d3f5394ad1e9fd01890e14
parentfcc51c95bcff73f377f4a2986d5cfb685b6af894
Revert of Add a Restore() method to ValueStore and make StorageAPI use it (https://codereview.chromium.org/165223003/)

Reason for revert:
Broke win unit_tests with StorageApiUnittest.RestoreStorage

Original issue's description:
> Add a Restore() method to ValueStore and make StorageAPI use it
> Take the first steps in preventing the Storage from getting and staying
> corrupted. This lets us Restore() a ValueStore when it's corrputed, and tries to
> do so in the StorageAPI calls.
> This also refactors so that there's a Local and Sync SettingsBackend - this has
> the added advantage of meaning we don't decorate the Local stores with Sync
> behavior.
> BUG=261623
>
> Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252617

TBR=mpcomplete@chromium.org,kalman@chromium.org,joaodasilva@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=261623

Review URL: https://codereview.chromium.org/175853002

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@252652 0039d316-1c4b-4281-b951-d872f2087c98
35 files changed:
chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.cc
chrome/browser/extensions/api/storage/leveldb_settings_storage_factory.h
chrome/browser/extensions/api/storage/local_storage_backend.cc [deleted file]
chrome/browser/extensions/api/storage/local_storage_backend.h [deleted file]
chrome/browser/extensions/api/storage/policy_value_store.cc
chrome/browser/extensions/api/storage/policy_value_store.h
chrome/browser/extensions/api/storage/settings_backend.cc [moved from chrome/browser/extensions/api/storage/sync_storage_backend.cc with 70% similarity]
chrome/browser/extensions/api/storage/settings_backend.h [moved from chrome/browser/extensions/api/storage/sync_storage_backend.h with 72% similarity]
chrome/browser/extensions/api/storage/settings_frontend.cc
chrome/browser/extensions/api/storage/settings_quota_unittest.cc
chrome/browser/extensions/api/storage/settings_storage_factory.h
chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.cc
chrome/browser/extensions/api/storage/settings_storage_quota_enforcer.h
chrome/browser/extensions/api/storage/settings_sync_unittest.cc
chrome/browser/extensions/api/storage/settings_test_util.cc
chrome/browser/extensions/api/storage/settings_test_util.h
chrome/browser/extensions/api/storage/storage_api.cc
chrome/browser/extensions/api/storage/storage_api.h
chrome/browser/extensions/api/storage/storage_api_unittest.cc [deleted file]
chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.cc
chrome/browser/extensions/api/storage/sync_or_local_value_store_cache.h
chrome/browser/extensions/api/storage/syncable_settings_storage.cc
chrome/browser/extensions/api/storage/syncable_settings_storage.h
chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.cc
chrome/browser/extensions/api/storage/weak_unlimited_settings_storage.h
chrome/browser/extensions/test_extension_system.cc
chrome/browser/extensions/test_extension_system.h
chrome/browser/value_store/leveldb_value_store.cc
chrome/browser/value_store/leveldb_value_store.h
chrome/browser/value_store/leveldb_value_store_unittest.cc
chrome/browser/value_store/testing_value_store.cc
chrome/browser/value_store/testing_value_store.h
chrome/browser/value_store/value_store.h
chrome/chrome_browser_extensions.gypi
chrome/chrome_tests_unit.gypi