| commit | d30268aa9bd90bd8dd885124cd1eb8f45053c08b | |
| author | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 25 Jun 2013 22:31:07 +0000 (25 22:31 +0000) | ||
| committer | pkasting@chromium.org <pkasting@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Tue, 25 Jun 2013 22:31:07 +0000 (25 22:31 +0000) | ||
| tree | b0b56ec35b800482d5770415b85140d6a2bf2c2c | treesnapshot (tar.gz zip) |
| parent | f3a1d40d66739544a90212f92dac4080c3f3df71 | commitdiff |
Increase number of matches SearchProvider can return to the full popup size,
assuming:
(1) Instant Extended is enabled (so we can get metrics comparing before/after)
(2) The extra matches come from server-scored suggestions. We allow the highest
ranking 3 non-verbatim matches to come from any source, but after that we only
allow server-scored matches (and verbatim matches) until we hit the result set
limit.
This requires extending the Result class in the search provider to track the
origin of each match's score, as well as recording this information in the
AutocompleteMatch's |additional_info| field.
Note that https://codereview.chromium.org/17391005/ will simplify this somewhat
since we'll be able to stop worrying about FinalizeInstantQuery() etc.
BUG=252506
TEST=With instant extended on, type a query that generates lots of suggestions and see you get a full dropdown worth.
R=mpearson@chromium.org, msw@chromium.org
Review URL: https://codereview.chromium.org/17382015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208567 0039d316-1c4b-4281-b951-d872f2087c98
assuming:
(1) Instant Extended is enabled (so we can get metrics comparing before/after)
(2) The extra matches come from server-scored suggestions. We allow the highest
ranking 3 non-verbatim matches to come from any source, but after that we only
allow server-scored matches (and verbatim matches) until we hit the result set
limit.
This requires extending the Result class in the search provider to track the
origin of each match's score, as well as recording this information in the
AutocompleteMatch's |additional_info| field.
Note that https://codereview.chromium.org/17391005/ will simplify this somewhat
since we'll be able to stop worrying about FinalizeInstantQuery() etc.
BUG=252506
TEST=With instant extended on, type a query that generates lots of suggestions and see you get a full dropdown worth.
R=mpearson@chromium.org, msw@chromium.org
Review URL: https://codereview.chromium.org/17382015
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@208567 0039d316-1c4b-4281-b951-d872f2087c98