Revert of Shard browser_ui on Windows: exceeding .lib limit in some configs (patchset...
commitd117e07511eb63bdd35b9151a96298ab8d99c065
authorscottmg <scottmg@chromium.org>
Wed, 19 Nov 2014 04:56:44 +0000 (18 20:56 -0800)
committerCommit bot <commit-bot@chromium.org>
Wed, 19 Nov 2014 04:57:04 +0000 (19 04:57 +0000)
tree6483fe92eed41a3f7ad5cc9864cc02f2541b97f5
parent355b5a97a8ab51f0a2800594013ec833a2f3a760
Revert of Shard browser_ui on Windows: exceeding .lib limit in some configs (patchset #1 id:1 of https://codereview.chromium.org/715193003/)

Reason for revert:
'obj\chrome\browser\ui\autofill\browser_ui_1.autofill_dialog_controller.obj',
> missing and no known rule to make it

will investigate.

Original issue's description:
> Shard browser_ui on Windows: exceeding .lib limit in some configs
>
> I didn't repro the failure, but got a lib very close to 0x80000000 with
> GYP_DEFINES=chromium_win_pch=0 component=static_library win_z7=1
>
> Release build:
> browser_ui.lib == 2,139,688,202
> limit == 2,147,483,648
>
> The next largest libs are
>
> 2014-11-17  10:04 AM     1,025,509,714 webcore_rendering.lib
> 2014-11-17  10:15 AM     1,057,642,452 browser_extensions.lib
> 2014-11-17  10:08 AM     1,191,471,886 webcore_html.lib
> 2014-11-17  10:12 AM     1,195,923,632 content_browser.lib
>
> so this will hopefully be sufficient for a while.
>
> They're a bit bigger in debug, but still OK:
>
>      1,103,906,098 webcore_rendering.lib
>      1,117,979,546 modules.lib
>      1,227,134,654 browser_extensions.lib
>      1,271,623,056 webcore_html.lib
>      1,444,640,992 content_browser.lib
>
> TBR=grt@chromium.org
> BUG=432748
>
> Committed: https://crrev.com/5ac560d02ebbd8f542e43a74b1a471145403e5d4
> Cr-Commit-Position: refs/heads/master@{#304704}

TBR=grt@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=432748

Review URL: https://codereview.chromium.org/715203003

Cr-Commit-Position: refs/heads/master@{#304765}
chrome/chrome_browser_ui.gypi