Introduce ProfileInvalidationProvider wrapper for InvalidationService
commitd03d2e1c530c0329de57e31e76390defe6cad676
authorbartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 12 Jun 2014 16:55:35 +0000 (12 16:55 +0000)
committerbartfab@chromium.org <bartfab@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98>
Thu, 12 Jun 2014 16:55:35 +0000 (12 16:55 +0000)
treedabe4be9eeb91d810ba2e8daea1995c88acee42d
parent9ba666117ed56d6ff4b1e058f9027798faa31b22
Introduce ProfileInvalidationProvider wrapper for InvalidationService

TiclInvalidationService was refactored to no longer depend on Profile.
However, it still is a KeyedService. While this does actually pull in
Profile as a dependency, it implies that TiclInvalidationService should
be considered a per-Profile service, like the other KeyedServices in
Chrome's code base.

This CL introduces ProfileInvalidationProvider, a KeyedService that is a
tiny wrapper around an InvalidationService. Given this wrapper,
InvalidationService (and with it, TiclInvalidationService) no longer have
to be KeyedServices.

BUG=362083
TEST=Updated unit and browser tests

TBR=dcheng (chrome/browser/extensions/api/push_messaging/*)
TBR=davemoore (chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc)
TBR=arv (chrome/browser/ui/webui/invalidations_message_handler.cc)

Review URL: https://codereview.chromium.org/327243003

git-svn-id: svn://svn.chromium.org/chrome/trunk/src@276715 0039d316-1c4b-4281-b951-d872f2087c98
39 files changed:
chrome/browser/drive/DEPS
chrome/browser/drive/drive_notification_manager.cc
chrome/browser/drive/drive_notification_manager_factory.cc
chrome/browser/extensions/api/push_messaging/push_messaging_api.cc
chrome/browser/extensions/api/push_messaging/push_messaging_apitest.cc
chrome/browser/invalidation/fake_invalidation_service.cc
chrome/browser/invalidation/fake_invalidation_service.h
chrome/browser/invalidation/invalidation_service_android_unittest.cc
chrome/browser/invalidation/invalidation_service_factory.h [deleted file]
chrome/browser/invalidation/invalidation_service_factory_browsertest.cc [deleted file]
chrome/browser/invalidation/profile_invalidation_provider_factory.cc [moved from chrome/browser/invalidation/invalidation_service_factory.cc with 79% similarity]
chrome/browser/invalidation/profile_invalidation_provider_factory.h [new file with mode: 0644]
chrome/browser/invalidation/profile_invalidation_provider_factory_browsertest.cc [new file with mode: 0644]
chrome/browser/invalidation/ticl_invalidation_service.cc
chrome/browser/invalidation/ticl_invalidation_service.h
chrome/browser/invalidation/ticl_invalidation_service_unittest.cc
chrome/browser/invalidation/ticl_profile_settings_provider_unittest.cc
chrome/browser/policy/cloud/cloud_policy_browsertest.cc
chrome/browser/policy/cloud/user_cloud_policy_invalidator.cc
chrome/browser/policy/cloud/user_cloud_policy_invalidator_factory.cc
chrome/browser/profiles/chrome_browser_main_extra_parts_profiles.cc
chrome/browser/sync/glue/sync_backend_host_impl_unittest.cc
chrome/browser/sync/profile_sync_service.cc
chrome/browser/sync/profile_sync_service_factory.cc
chrome/browser/sync/profile_sync_service_typed_url_unittest.cc
chrome/browser/sync/profile_sync_service_unittest.cc
chrome/browser/sync/test/integration/fake_server_invalidation_service.cc
chrome/browser/sync/test/integration/fake_server_invalidation_service.h
chrome/browser/sync/test/integration/sync_test.cc
chrome/browser/sync/test_profile_sync_service.cc
chrome/browser/ui/webui/invalidations_message_handler.cc
chrome/chrome_browser.gypi
chrome/chrome_tests.gypi
components/invalidation.gypi
components/invalidation/invalidation_service.h
components/invalidation/p2p_invalidation_service.cc
components/invalidation/p2p_invalidation_service.h
components/invalidation/profile_invalidation_provider.cc [new file with mode: 0644]
components/invalidation/profile_invalidation_provider.h [new file with mode: 0644]