| commit | cfa7093b5171b9aa3027d9d017ce79e64740527b | |
| author | maxbogue <maxbogue@chromium.org> | |
| Mon, 24 Nov 2014 23:05:40 +0000 (24 15:05 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Mon, 24 Nov 2014 23:06:03 +0000 (24 23:06 +0000) | ||
| tree | ee8e8d7edcb82c18494b9da90ddd2134886f45dd | treesnapshot (tar.gz zip) |
| parent | 971235610c0142f602b87c4e9c5d3770409fad4a | commitdiff |
Add UMA counting for Sync Attachments response codes.
sync/util/data_type_histogram_unittest.cc had to be edited
because it initialized different types of histograms with
identical names. Previously this did not crash because the
tests had failed to invoke StatisticsRecorder::Initialize().
The HistogramTester this CL introduces in the attachments
unittests does that initialization, so things broke in fun
and unexpected ways.
BUG=436134
Review URL: https://codereview.chromium.org/728323003
Cr-Commit-Position: refs/heads/master@{#305514}
sync/util/data_type_histogram_unittest.cc had to be edited
because it initialized different types of histograms with
identical names. Previously this did not crash because the
tests had failed to invoke StatisticsRecorder::Initialize().
The HistogramTester this CL introduces in the attachments
unittests does that initialization, so things broke in fun
and unexpected ways.
BUG=436134
Review URL: https://codereview.chromium.org/728323003
Cr-Commit-Position: refs/heads/master@{#305514}