| commit | cf39956aa6b49e0017829d1dabffe7874c18fc08 | |
| author | yukishiino <yukishiino@chromium.org> | |
| Tue, 27 Jan 2015 08:02:14 +0000 (27 00:02 -0800) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 27 Jan 2015 08:03:49 +0000 (27 08:03 +0000) | ||
| tree | 7e3bbbed726d4b3dd6edf48e2186cf2a8c684150 | treesnapshot (tar.gz zip) |
| parent | 7d38eadfc35ba445428211ab673c4b89f6978716 | commitdiff |
text input focus: Updates WebView::GetTextInputClient when the underlying RenderView is destroyed.
This CL is split off from http://crrev.com/785463002 .
WebView implements RenderProcessHostObserver and updates the text input client when the render process exits (i.e. the underlying RenderView / RWHVA are going to be destroyed). Because WebView::GetTextInputClient() returns RWHVA::GetTextInputClient(), we need to discard a reference to the object returned by RWHVA::GetTextInputClient() before RWHVA is destroyed.
BUG=290701
TEST=Run interactive_ui_tests.
Review URL: https://codereview.chromium.org/862643002
Cr-Commit-Position: refs/heads/master@{#313240}
This CL is split off from http://crrev.com/785463002 .
WebView implements RenderProcessHostObserver and updates the text input client when the render process exits (i.e. the underlying RenderView / RWHVA are going to be destroyed). Because WebView::GetTextInputClient() returns RWHVA::GetTextInputClient(), we need to discard a reference to the object returned by RWHVA::GetTextInputClient() before RWHVA is destroyed.
BUG=290701
TEST=Run interactive_ui_tests.
Review URL: https://codereview.chromium.org/862643002
Cr-Commit-Position: refs/heads/master@{#313240}
| ui/views/controls/webview/webview.cc | diffblobblamehistory | |
| ui/views/controls/webview/webview.h | diffblobblamehistory | |
| ui/views/controls/webview/webview_interactive_uitest.cc | diffblobblamehistory |