| commit | cd886410d9df48ab930f5bfdfdf761b2ecf4ba76 | |
| author | jianli <jianli@chromium.org> | |
| Tue, 14 Oct 2014 23:16:14 +0000 (14 16:16 -0700) | ||
| committer | Commit bot <commit-bot@chromium.org> | |
| Tue, 14 Oct 2014 23:16:32 +0000 (14 23:16 +0000) | ||
| tree | 79386aa39bf183d081dc7f17b37a73f35be410a7 | treesnapshot (tar.gz zip) |
| parent | acec86f50047d33fa4e3429ba61f56546a332cc7 | commitdiff |
Revert of [GCM] Start GCMChannelStatusSyncer when GCM is disabled (patchset #2 id:20001 of https://codereview.chromium.org/653843003/)
Reason for revert:
Reverted due to that the fix is not complete. Will fix one more issue we find and reland the patch.
Original issue's description:
> [GCM] Start GCMChannelStatusSyncer when GCM is disabled
>
> We need to start GCMChannelStatusSyncer when GCM is disabled in order
> to poll the server to find out when it is reenabled.
>
> Also if server returns empty response, we should not treat it as error
> and trigger the backoff logic.
>
> BUG=423415
> TEST=new tests added
>
> Committed: https://crrev.com/9e9dd3b7798b3500d70941af04b1325ef9a0b544
> Cr-Commit-Position: refs/heads/master@{#299518}
TBR=fgorski@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423415
Review URL: https://codereview.chromium.org/657703002
Cr-Commit-Position: refs/heads/master@{#299579}
Reason for revert:
Reverted due to that the fix is not complete. Will fix one more issue we find and reland the patch.
Original issue's description:
> [GCM] Start GCMChannelStatusSyncer when GCM is disabled
>
> We need to start GCMChannelStatusSyncer when GCM is disabled in order
> to poll the server to find out when it is reenabled.
>
> Also if server returns empty response, we should not treat it as error
> and trigger the backoff logic.
>
> BUG=423415
> TEST=new tests added
>
> Committed: https://crrev.com/9e9dd3b7798b3500d70941af04b1325ef9a0b544
> Cr-Commit-Position: refs/heads/master@{#299518}
TBR=fgorski@chromium.org
NOTREECHECKS=true
NOTRY=true
BUG=423415
Review URL: https://codereview.chromium.org/657703002
Cr-Commit-Position: refs/heads/master@{#299579}