| commit | c8c0ca6bf44b5c456fb020c9f00b3b419f548154 | |
| author | rileya@chromium.org <rileya@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 28 Feb 2014 20:30:44 +0000 (28 20:30 +0000) | ||
| committer | rileya@chromium.org <rileya@chromium.org@0039d316-1c4b-4281-b951-d872f2087c98> | |
| Fri, 28 Feb 2014 20:30:44 +0000 (28 20:30 +0000) | ||
| tree | c648369d770ef08efaeb2f228aa0d699302d0a0a | treesnapshot (tar.gz zip) |
| parent | c2700ca59261ac1496868567b2c217de2b1c19a7 | commitdiff |
Clean up histogram'd media enum max values.
This adds a PRESUBMIT test to src/media/ which enforces the following when using UMA_HISTOGRAM_ENUMERATION:
- The max enum value should be suffixed with 'MAX' or 'Max' (and it should be equal to the largest valid entry ever logged).
- One should be added to that max value when used in the UMA_HISTOGRAM_ENUMERATION macro.
To handle past misuses of UMA_HISTOGRAM_ENUMERATION for non-enums a comment of '// IGNORE_PRESUBMIT_UMA_MAX' was added to silence the presubmit check.
BUG=165553
TBR=danakj
Review URL: https://codereview.chromium.org/148553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254209 0039d316-1c4b-4281-b951-d872f2087c98
This adds a PRESUBMIT test to src/media/ which enforces the following when using UMA_HISTOGRAM_ENUMERATION:
- The max enum value should be suffixed with 'MAX' or 'Max' (and it should be equal to the largest valid entry ever logged).
- One should be added to that max value when used in the UMA_HISTOGRAM_ENUMERATION macro.
To handle past misuses of UMA_HISTOGRAM_ENUMERATION for non-enums a comment of '// IGNORE_PRESUBMIT_UMA_MAX' was added to silence the presubmit check.
BUG=165553
TBR=danakj
Review URL: https://codereview.chromium.org/148553003
git-svn-id: svn://svn.chromium.org/chrome/trunk/src@254209 0039d316-1c4b-4281-b951-d872f2087c98
31 files changed: